Skip to content

Conversation

@raffaelladevita
Copy link
Collaborator

Starting from 0.41, ejml-simple implements a new class ConstMatrix. This is not found at run time because the coat-lib jar contains two versions of this dependency, the other one being version 0.40 pulled by j4ml.
It never surfaced before because it is used only by the CVTAlignment service

@baltzell
Copy link
Collaborator

What's the easiest way to reproduce this runtime error? Apparently none of our tests are sensitive to it.

@raffaelladevita
Copy link
Collaborator Author

Include the CVTAlignment service in the yaml

@c-dilks
Copy link
Member

c-dilks commented May 16, 2025

Apparently none of our tests are sensitive to it.

Supposedly maven-enforcer-plugin can deal with this; but first we probably need to clean our dependency graph, #632.

@c-dilks
Copy link
Member

c-dilks commented May 16, 2025

Supposedly maven-enforcer-plugin can deal with this

Yep. For example:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce-dependency-convergence) on project clas-io:
[ERROR] Rule 0: org.apache.maven.enforcer.rules.dependency.DependencyConvergence failed with message:
[ERROR] Failed while enforcing releasability.
[ERROR]
[ERROR] Dependency convergence error for net.objecthunter:exp4j:jar:0.4.4 paths to dependency are:
[ERROR] +-org.jlab.clas:clas-io:jar:12.0.6t-SNAPSHOT
[ERROR]   +-org.jlab.jnp:jnp-hipo:jar:2.0-SNAPSHOT:compile
[ERROR]     +-net.objecthunter:exp4j:jar:0.4.4:compile
[ERROR] and
[ERROR] +-org.jlab.clas:clas-io:jar:12.0.6t-SNAPSHOT
[ERROR]   +-org.jlab.jnp:jnp-hipo4:jar:4.3-SNAPSHOT:compile
[ERROR]     +-net.objecthunter:exp4j:jar:0.4.8:compile

@c-dilks
Copy link
Member

c-dilks commented May 16, 2025

And I've found the enforcer also catches the one here (among many many more conflicts):

[ERROR] Dependency convergence error for org.ejml:ejml-simple:jar:0.40 paths to dependency are:
[ERROR] +-org.jlab.clas:coat-libs:jar:12.0.6t-SNAPSHOT
[ERROR]   +-j4ml:j4ml-clas12:jar:0.9-SNAPSHOT:compile
[ERROR]     +-org.ejml:ejml-simple:jar:0.40:compile
[ERROR] and
[ERROR] +-org.jlab.clas:coat-libs:jar:12.0.6t-SNAPSHOT
[ERROR]   +-org.jlab.clas:clas-tracking:jar:12.0.6t-SNAPSHOT:compile
[ERROR]     +-org.ejml:ejml-simple:jar:0.44.0:compile

@raffaelladevita
Copy link
Collaborator Author

And I've found the enforcer also catches the one here (among many many more conflicts):

[ERROR] Dependency convergence error for org.ejml:ejml-simple:jar:0.40 paths to dependency are:
[ERROR] +-org.jlab.clas:coat-libs:jar:12.0.6t-SNAPSHOT
[ERROR]   +-j4ml:j4ml-clas12:jar:0.9-SNAPSHOT:compile
[ERROR]     +-org.ejml:ejml-simple:jar:0.40:compile
[ERROR] and
[ERROR] +-org.jlab.clas:coat-libs:jar:12.0.6t-SNAPSHOT
[ERROR]   +-org.jlab.clas:clas-tracking:jar:12.0.6t-SNAPSHOT:compile
[ERROR]     +-org.ejml:ejml-simple:jar:0.44.0:compile

That's the one

@baltzell baltzell merged commit 8aa1327 into dev-align-merge May 19, 2025
32 checks passed
@baltzell baltzell deleted the iss633-dev-align-merge-ejml branch May 19, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants