-
Notifications
You must be signed in to change notification settings - Fork 26
Decoder cleanup #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Decoder cleanup #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raffaelladevita
previously approved these changes
Aug 29, 2025
c-dilks
reviewed
Sep 4, 2025
common-tools/clas-utils/src/main/java/org/jlab/utils/options/OptionParser.java
Show resolved
Hide resolved
common-tools/clas-detector/src/main/java/org/jlab/detector/decode/CLASDecoder4U.java
Show resolved
Hide resolved
9f4e5af to
ec49e3a
Compare
Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
raffaelladevita
approved these changes
Sep 13, 2025
c-dilks
added a commit
that referenced
this pull request
Sep 15, 2025
* relax * add decoder wrapper * cache data from xrootd * fix xrootd path, reduce job length * use old, working path for now * add constructor * reuse parser * fix up test/main method * add missing parse * restore not-really-supported options * Update .github/workflows/ci.yml Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com> --------- Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
tongtongcao
pushed a commit
that referenced
this pull request
Sep 22, 2025
* relax * add decoder wrapper * cache data from xrootd * fix xrootd path, reduce job length * use old, working path for now * add constructor * reuse parser * fix up test/main method * add missing parse * restore not-really-supported options * Update .github/workflows/ci.yml Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com> --------- Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
tongtongcao
pushed a commit
that referenced
this pull request
Nov 18, 2025
* relax * add decoder wrapper * cache data from xrootd * fix xrootd path, reduce job length * use old, working path for now * add constructor * reuse parser * fix up test/main method * add missing parse * restore not-really-supported options * Update .github/workflows/ci.yml Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com> --------- Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
tongtongcao
pushed a commit
that referenced
this pull request
Nov 21, 2025
* relax * add decoder wrapper * cache data from xrootd * fix xrootd path, reduce job length * use old, working path for now * add constructor * reuse parser * fix up test/main method * add missing parse * restore not-really-supported options * Update .github/workflows/ci.yml Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com> --------- Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decoder's main method into a new classmainmethodhasNext/getNextinterface