Define a default startTime for simulation or ALERT-only reconstruction #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftouchte
requested review from
N-Plx,
baltzell,
efuchey,
mathieuouillon,
mpaolone and
whit2333
as code owners
mathieuouillon
approved these changes
Aug 26, 2025
Collaborator
mathieuouillon
left a comment
mathieuouillon
left a comment
There was a problem hiding this comment.
Looks good for me. It fixed the issue with the simulation.
c-dilks
pushed a commit
that referenced
this pull request
Sep 15, 2025
tongtongcao
pushed a commit
that referenced
this pull request
Sep 22, 2025
tongtongcao
pushed a commit
that referenced
this pull request
Nov 18, 2025
tongtongcao
pushed a commit
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also fixes another issue : this kind of cuts should be done at the analysis level, not here.