remove optical properties from Plexiglass#84
Merged
Conversation
rjones30
reviewed
Mar 24, 2025
Contributor
rjones30
left a comment
There was a problem hiding this comment.
Good idea, this might have been useful for generating light in the FCAL plexi light guides, but at the moment we are using energy deposition in the plexi as a proxy for Cerenkov light instead of actual Cerenkov photon generation. -Richard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to avoid generating Cherenkov photons outside of the sensitive regions for the DIRC