Skip to content

Conversation

@baltzell
Copy link
Collaborator

@baltzell baltzell commented Jun 27, 2025

This won't build unless it uses the new github maven repo for lcsim (which only contains 4.5.0 and is the only maven repo containing 4.5.0). And the build should fail with this (I assume):

[ERROR] /u/scihome/baltzell/sw/hps-java/tracking/src/main/java/org/hps/recon/tracking/kalman/KalmanDriverHPS.java:[530,59] method computeMomentum in class org.lcsim.event.base.BaseTrackState cannot be applied to given types;
[ERROR]   required: no arguments
[ERROR]   found:    double
[ERROR]   reason: actual and formal argument lists differ in length

@baltzell baltzell requested a review from Copilot June 27, 2025 22:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the lcsim dependency version to 4.5.0 to ensure compatibility with the new GitHub Maven repository containing the required version.

  • Updated lcsim version from 4.4.0 to 4.5.0 in pom.xml
Comments suppressed due to low confidence (1)

pom.xml:22

  • Ensure that the Maven repository configuration is updated to point to the new GitHub Maven repository that hosts lcsim 4.5.0, otherwise the build may fail as indicated in the PR description.
    <lcsimVersion>4.5.0</lcsimVersion>

@baltzell
Copy link
Collaborator Author

Hmm, the CI jobs get a different error than the new lcsim/hps-java incompatibility I mentioned above. Can anyone reproduce either?

@bloodyyugo
Copy link
Contributor

Hmm, the CI jobs get a different error than the new lcsim/hps-java incompatibility I mentioned above. Can anyone reproduce either?

I get this when I checkout and build this branch:

ERROR] Failed to execute goal on project hps-util: Could not collect dependencies for project org.hps:hps-util:jar:5.2.2-SNAPSHOT
[ERROR] Failed to read artifact descriptor for org.lcsim:lcsim-event-processing:jar:4.5.0
[ERROR] Caused by: The following artifacts could not be resolved: org.lcsim:lcsim-event-processing:pom:4.5.0 (absent): Could not transfer artifact org.lcsim:lcsim-event-processing:pom:4.5.0 from/to github (https://maven.pkg.github.com/jeffersonlab/hps-lcsim): status code: 401, reason phrase: Unauthorized (401)
[ERROR] Failed to read artifact descriptor for org.lcsim:lcsim-aida:jar:4.5.0
[ERROR] Caused by: The following artifacts could not be resolved: org.lcsim:lcsim-aida:pom:4.5.0 (absent): Could not transfer artifact org.lcsim:lcsim-aida:pom:4.5.0 from/to github (https://maven.pkg.github.com/jeffersonlab/hps-lcsim): status code: 401, reason phrase: Unauthorized (401)
[ERROR] Failed to read artifact descriptor for org.lcsim:lcsim-tracking:jar:4.5.0
[ERROR] Caused by: The following artifacts could not be resolved: org.lcsim:lcsim-tracking:pom:4.5.0 (absent): Could not transfer artifact org.lcsim:lcsim-tracking:pom:4.5.0 from/to github (https://maven.pkg.github.com/jeffersonlab/hps-lcsim): status code: 401, reason phrase: Unauthorized (401)


@baltzell
Copy link
Collaborator Author

baltzell commented Jul 1, 2025

Ah, sorry, lcsim-4.5.0 was in my local maven repo from building it locally. Yes, apparently github requires authentication for even reading their maven repos (and maven is happy if you have it in your local maven and it doesn't exist remotely, weird), grrr .... For the moment, can you try putting this in your ~/.m2 (with your username and token):

<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
                      http://maven.apache.org/xsd/settings-1.0.0.xsd">
  <activeProfiles>
    <activeProfile>github</activeProfile>
  </activeProfiles>
  <profiles>
    <profile>
      <id>github</id>
      <repositories>
        <repository>
          <id>central</id>
          <url>https://repo1.maven.org/maven2</url>
        </repository>
        <repository>
          <id>github</id>
          <url>https://maven.pkg.github.com/jeffersonlab/hps-lcsim</url>
          <snapshots>
            <enabled>true</enabled>
          </snapshots>
        </repository>
      </repositories>
    </profile>
  </profiles>
  <servers>
    <server>
      <id>github</id>
      <username>USERNAME</username>
      <password>TOKEN</password>
    </server>
  </servers>
</settings>

@baltzell
Copy link
Collaborator Author

baltzell commented Jul 1, 2025

Progress: using the secret token thingy gets the CI job to here:
Screenshot 2025-06-30 at 20 19 31

@baltzell
Copy link
Collaborator Author

baltzell commented Jul 7, 2025

superseded by #1115

@baltzell baltzell closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants