-
Notifications
You must be signed in to change notification settings - Fork 12
lcsim 4.5.0 #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lcsim 4.5.0 #1114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the lcsim dependency version to 4.5.0 to ensure compatibility with the new GitHub Maven repository containing the required version.
- Updated lcsim version from 4.4.0 to 4.5.0 in pom.xml
Comments suppressed due to low confidence (1)
pom.xml:22
- Ensure that the Maven repository configuration is updated to point to the new GitHub Maven repository that hosts lcsim 4.5.0, otherwise the build may fail as indicated in the PR description.
<lcsimVersion>4.5.0</lcsimVersion>
|
Hmm, the CI jobs get a different error than the new lcsim/hps-java incompatibility I mentioned above. Can anyone reproduce either? |
I get this when I checkout and build this branch: ERROR] Failed to execute goal on project hps-util: Could not collect dependencies for project org.hps:hps-util:jar:5.2.2-SNAPSHOT |
|
Ah, sorry, lcsim-4.5.0 was in my local maven repo from building it locally. Yes, apparently github requires authentication for even reading their maven repos (and maven is happy if you have it in your local maven and it doesn't exist remotely, weird), grrr .... For the moment, can you try putting this in your |
|
Progress: using the secret token thingy gets the CI job to here: |
|
superseded by #1115 |

This won't build unless it uses the new github maven repo for lcsim (which only contains 4.5.0 and is the only maven repo containing 4.5.0). And the build should fail with this (I assume):