Iss135: create SiliconResolutionModel for use in strip making #217
Merged
normangraf merged 7 commits intomasterfrom Oct 18, 2017
Merged
Iss135: create SiliconResolutionModel for use in strip making #217normangraf merged 7 commits intomasterfrom
normangraf merged 7 commits intomasterfrom
Conversation
interface SiliconResolutionModel. Also created a DefaultSiliconResolutionModel which basically does the same sort of things that the original code did.
SiliconResolutionModel
normangraf
approved these changes
Oct 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a proper framework, in tracking/src/main/java/org/hps/recon/tracking/SiliconResolutionModel.java and DefaultSiliconResolutionModel.java, to deal with resolution (in measured and unmeasured coord, based on number of hits) and position (weighted or unweighted) for a cluster. StripMaker now has a SiliconResolutionModel member, rather than doing the resolution and position calculations itself; TrackDataDriver creates a SiliconResolutionModel and gives it to the StripMaker. Currently, the values in DefaultSiliconResolutionModel are set to produce exactly the same results as master, as verified by the tracking unit tests on branch iss135. At some point, these values can be changed (or a more complicated SiliconResolutionModel class can be built) based on MC and/or data-driven studies.
Passes integration tests.