Iss57: 3D hits from hole + slot strip hit#219
Merged
normangraf merged 5 commits intomasterfrom Oct 18, 2017
Merged
Conversation
normangraf
approved these changes
Oct 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified hps-tracking > recon.tracking.HelicalTrackHitDriver , so that it can make a 3D hit in Layers 4-6 from an axial strip-hit on a hole sensor + a stereo strip-hit on the adjacent slot sensor (or vice-versa). The settable allowHoleSlotCombo switch controls whether or not this behavior is allowed. By default it is set to false, which gives the same results as the master. When set to true, it yields 1043 new HelicalTrackHits in 10K data events, and 21 new HelicalTrackHits in 1700 prompt A' MC events. (Also re-factored some of the HelicalTrackHitDriver code, to make it more manageable and remove some outdated 'common geometry' clutter)
Passes integration tests with allowHoleSlotCombo=false