changes to tracking to resolve L0 not using L6#25
Merged
omar-moreno merged 1 commit intomasterfrom Feb 16, 2017
Merged
Conversation
Contributor
|
I'm not that familiar with the details of this but this XML seems very "hacky" ... Why do you need to pass in a layer number to this Driver? |
Collaborator
|
Yes.
…On Feb 16, 2017 1:58 PM, "Jeremy McCormick" ***@***.***> wrote:
I'm not that familiar with the details of this but this XML seems very
"hacky" ...
<driver name="TrackDataDriver" type="org.hps.recon.tracking.TrackDataDriver">
<layerNum>7</layerNum>
</driver>
Why do you need to pass in a layer number to this Driver?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADiWXOXKTNPRJukp6i0kql3CzcpfX7Tjks5rdMZ0gaJpZM4MDk4d>
.
|
omar-moreno
approved these changes
Feb 16, 2017
Collaborator
omar-moreno
left a comment
omar-moreno
left a comment
There was a problem hiding this comment.
At some point we will change this to make it more generic, for now this is fine.
alspellm
pushed a commit
to alspellm/hps-java
that referenced
this pull request
Sep 2, 2020
Fix the "no arguments" bug.
alspellm
pushed a commit
to alspellm/hps-java
that referenced
this pull request
Sep 2, 2020
Fix the "no arguments" bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking is probably fixed.