Iss31#32
Merged
omar-moreno merged 2 commits intomasterfrom Feb 21, 2017
Merged
Conversation
omar-moreno
approved these changes
Feb 21, 2017
Collaborator
omar-moreno
left a comment
omar-moreno
left a comment
There was a problem hiding this comment.
At some point, the field map should be taken into account in the extrapolation. For now, using the analytic extrapolator is fine.
| Hep3Vector extrapTrackPosL1; | ||
| Hep3Vector extrapTrackPosL2; | ||
| if(trackState.getTanLambda() > 0){ | ||
| extrapTrackPosL0 = TrackUtils.extrapolateTrack(track,topPos[0]); |
Collaborator
There was a problem hiding this comment.
In the future, you should switch to using the extrapolator which makes use of the field map. The analytic extrapolator should be fine for L1-L2 but I'm not certain it will give the most accurate results for L0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding track extrapolation variables to the tuple maker for layer 0-2.