added detector HPS-PhysicsRun2016-v5-3-fieldmap_globalAlign#75
Merged
omar-moreno merged 2 commits intomasterfrom May 17, 2017
Merged
added detector HPS-PhysicsRun2016-v5-3-fieldmap_globalAlign#75omar-moreno merged 2 commits intomasterfrom
omar-moreno merged 2 commits intomasterfrom
Conversation
Collaborator
|
@sebouh137 For future reference, when you create a branch, follow the naming convention iss. Makes it easier to find the related issue when reviewing a pull request. |
Collaborator
|
@afilippi67 Can you verify that the detector uses the correct constants. It's worth having another pair of eyes on this. |
Collaborator
|
the file matches my original version, on my account the merge is approved |
omar-moreno
approved these changes
May 17, 2017
Collaborator
omar-moreno
left a comment
omar-moreno
left a comment
There was a problem hiding this comment.
Alignment constants were verified by @afilippi67 so I approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alignments from an xml file that Alessandra sent me in an email