Add track state at target #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tracks with references to original track
…arget tracks, save tracks with relations to AtIP tracks. To turn on tracks at target, must pass target position in steering-file under KalmanPatRecDriver
cbravo135
reviewed
Jun 9, 2023
| if (case2){ | ||
| double [] paramsRefPoint = {finalPos.x(), finalPos.y(), 0.0}; | ||
| bts.setReferencePoint(paramsRefPoint); | ||
| double[] newRef = {-4.3, 0.0, 0.0}; |
Collaborator
There was a problem hiding this comment.
I think you want to change -4.3 to target_z
Contributor
Author
|
Ah you are correct, whoops
…On Thu, Jun 8, 2023, 6:00 PM Cameron Bravo ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tracking/src/main/java/org/hps/recon/tracking/TrackUtils.java
<#996 (comment)>
:
> + double dx = dz * mom.x() / mom.z();
+ Hep3Vector dPos = new BasicHep3Vector(dx, dy, dz);
+ finalPos = CoordinateTransformations.transformVectorToTracking(VecOp.add(dPos, RKresults.getFirstElement()));
+ }
+ bFieldY = fM.getField(CoordinateTransformations.transformVectorToDetector(finalPos)).y();
+ //params are calculated with respect to ref = {trackX, trackY, z=0)
+ double[] params = getParametersFromPointAndMomentum(finalPos, momTrans, (int) charge, bFieldY);
+ BaseTrackState bts = new BaseTrackState(params, bFieldY);
+ //reference point is set to track position in X Y Z
+ bts.setReferencePoint(finalPos.v());
+ //Consider shifting reference point to (trackX, 0, 0)...otherwise d0=0
+ boolean case2 = false;
+ if (case2){
+ double [] paramsRefPoint = {finalPos.x(), finalPos.y(), 0.0};
+ bts.setReferencePoint(paramsRefPoint);
+ double[] newRef = {-4.3, 0.0, 0.0};
I think you want to change -4.3 to target_z
—
Reply to this email directly, view it on GitHub
<#996 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALKJUAVYERXF6YNS4FFFX43XKJYT7ANCNFSM6AAAAAAY75AKSI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…mment out so that by default, no track state at target is created unless user specifies target position
…mspot positions from db
bloodyyugo
approved these changes
Jun 15, 2023
…ta class. Allows us to calculate track momentum using curvature later, instead of having to create a new TrackData collection to hold 3-momentum for each Track State
Contributor
|
Instead of having magic code triggered by the addition of the targetPosition variable please add a boolean which explicitly states what is going to happen followed by the target location, such as
|
pbutti
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extrap track to target and make new track state where track params ref = (trackX,trackY,0), therefore d0 = 0.
trackY position may replace d0 if using this track state in analysis.
Track reference point is set to (trackX, trackY, trackZ), so track position at target is saved.
May want to change track param reference point to ref = (trackX,0,0), so that d0 != 0.
These track states only exist if target position is set in steering-file KalmanPatRecDriver.