remove dependence on VTPBank collection#209
Merged
mgignac merged 2 commits intoJeffersonLab:masterfrom Apr 4, 2025
Merged
Conversation
mgignac
reviewed
Apr 2, 2025
Collaborator
mgignac
left a comment
mgignac
left a comment
There was a problem hiding this comment.
Thanks @sarahgaiser ! Code looks good to me!
We should probably also disable this from the config level too, otherwise the vtpCollLcio/Root will be set: https://github.com/JeffersonLab/hpstr/blob/master/processors/config/recoTuple_noHitColl_cfg.py#L58 (and also the nominal recoTuple_cfg.py, which is used for MC).
mgignac
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VTPBank collection is not used for both MC and data. Currently, the collection does not exist in MC and will be removed for data in future passes. However, the EventProcessor currently defaults to querying the trigger information from the EventHeader (2016 style) if the VTPBank collection cannot be found. For 2019 and 2021, we would like to instead use the TSBank collection to get the trigger information.
To ensure that the correct collection is used for the trigger information, I have added a
year_variable to the EventProcessor instead of having some faulty automatic determination.year_is set to 2021 per default but can be configured to any other year.