Rga common analysis functions :: FiducialFilter #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 9, 2025 17:49
… make CalLayers public
… make CalLayers public
… make CalLayers public; added yamlreader
… make CalLayers public; added yamlreader
… make CalLayers public; added yamlreader
…against PCal, ECin and ECout histograms
…runtime override with strictness == 1 defined in Validator.cc for RGAFiducialFilter
…s lw and lv vs lu for electrons and photons
…s lw and lv vs lu for electrons and photons
…nction rather than reading from environmental variable
… tagger fiducial cuts alongside existing calorimeter cuts, updated validator to produce 1x2 canvas of electrons' and photons' x and y positions after cuts
…ts if that detectors' associated bank is present in the file
… meson.build for RGAFiducialFilter. Track banks will be discovered at run time (FT may not have a hit)
… meson.build for RGAFiducialFilter. Track banks will be discovered at run time (FT may not have a hit)
… meson.build for RGAFiducialFilter. Track banks will be discovered at run time (FT may not have a hit)
… meson.build for RGAFiducialFilter. Track banks will be discovered at run time (FT may not have a hit)
… meson.build for RGAFiducialFilter. Track banks will be discovered at run time (FT may not have a hit)
… meson.build for RGAFiducialFilter. Track banks will be discovered at run time (FT may not have a hit)
… meson.build for RGAFiducialFilter. Track banks will be discovered at run time (FT may not have a hit)
added 12 commits
September 25, 2025 20:16
…pearing because it was also requiring they pass DC cuts simultaneously
…histograms and TFile in stop()
…e releasing every ROOT object created
…e releasing every ROOT object created
c-dilks
reviewed
Oct 6, 2025
Member
c-dilks
left a comment
c-dilks
left a comment
There was a problem hiding this comment.
Here are some minor comments, which should be easy to to take care of. I'll have more comments later, since I haven't had a chance yet to read the full algorithm.
Member
c-dilks
reviewed
Oct 8, 2025
Member
c-dilks
left a comment
c-dilks
left a comment
There was a problem hiding this comment.
A few more minor comments. I think after this it'll be good to merge!
added 9 commits
October 13, 2025 11:38
…omments, removed hard coded detector numbers and replaced with enum DetectorType, changed pi to M_PI
… remove GetOptionVectorOrDefault usage
… remove GetOptionVectorOrDefault usage
…m; removes small sub-threshold tail in “after” plots
…updated accordingly
…updated accordingly
c-dilks
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new filter algorithm RGAFiducialFilter with support for RGA "pass-2" DC, CAL, CVT and FT fiducial cuts for relevant tracks. Filter checks each track in REC::Particle and applies the appropriate detector cuts. Default "RGA approved" values are stored in the associated Config.yaml for the DC region edge cuts, calorimeter lv & lw cuts, holes in forward tagger and gaps between sectors in CVT. These values can be changed by modifying the Config.yaml.
Strictness (default = 1) can be set as 1,2,3 by the user to increase tightness of calorimeter cuts. Future updates for run-by-run cuts on dead PMTs, regions of DC and CVT, etc. are planned.
Validator creates plots of FT electrons and photons before and after cuts, DC inbending and outbending tracks for region 1, 2 and 3 before and after cuts, CAL lv and lw distributions before and after cuts and CVT theta vs phi for all hadrons before and after cuts.