Include secret findings in GDPR report summary and processing categories#13
Merged
Jeffrin-dev merged 1 commit intomainfrom Mar 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
scan_result.secrets_foundin the report summary or processing categories, so secrets were missing fromsummary.detected_entity_typesandprocessing.categories_of_personal_data.Description
generate_gdpr_report()inshadowaudit/reports/gdpr_report.pyto collectscan_result.secrets_foundand increment a synthetic"SECRET"entity in theentity_counterwhen secrets are present.categories_of_personal_datafrom the entity keys and appended"API keys and credentials"when theSECRETentity is present._event()intests/test_audit_and_reports.pyto accept asecretsargument and addedtest_generate_gdpr_report_includes_secrets_in_summary_and_processing()that writes an event with secrets and asserts the report includes theSECRETcount and theAPI keys and credentialscategory.Testing
pytest -q tests/test_audit_and_reports.pyand all tests passed (3 passed).Codex Task