Skip to content

Include secret findings in GDPR report summary and processing categories#13

Merged
Jeffrin-dev merged 1 commit intomainfrom
codex/fix-gdpr-report-secret-counting
Mar 29, 2026
Merged

Include secret findings in GDPR report summary and processing categories#13
Jeffrin-dev merged 1 commit intomainfrom
codex/fix-gdpr-report-secret-counting

Conversation

@Jeffrin-dev
Copy link
Copy Markdown
Owner

Motivation

  • The GDPR report generator did not represent secret findings from scan_result.secrets_found in the report summary or processing categories, so secrets were missing from summary.detected_entity_types and processing.categories_of_personal_data.

Description

  • Updated generate_gdpr_report() in shadowaudit/reports/gdpr_report.py to collect scan_result.secrets_found and increment a synthetic "SECRET" entity in the entity_counter when secrets are present.
  • Constructed categories_of_personal_data from the entity keys and appended "API keys and credentials" when the SECRET entity is present.
  • Extended the test helper _event() in tests/test_audit_and_reports.py to accept a secrets argument and added test_generate_gdpr_report_includes_secrets_in_summary_and_processing() that writes an event with secrets and asserts the report includes the SECRET count and the API keys and credentials category.

Testing

  • Ran pytest -q tests/test_audit_and_reports.py and all tests passed (3 passed).

Codex Task

@Jeffrin-dev Jeffrin-dev merged commit be634e2 into main Mar 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant