Fix jelly-text support in AOT builds #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #128 Turns out that the Google proto classes require reflection for text serialization -- this was something that scalapb did not require. To fix this, we could hardcode the methods and classes that need to have reflective access enabled, but it would be a mess to maintain. Instead, we have a custom Graal feature that discovers the needed classes and registers them for reflective access.
Karolina-Bogacka
requested changes
May 31, 2025
Collaborator
Karolina-Bogacka
left a comment
Karolina-Bogacka
left a comment
There was a problem hiding this comment.
Aside from a tiny spelling error everything looks fine
src/main/scala/eu/neverblink/jelly/cli/graal/ProtobufFeature.scala
Outdated
Show resolved
Hide resolved
Karolina-Bogacka
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128
Turns out that the Google proto classes require reflection for text serialization -- this was something that scalapb did not require.
To fix this, we could hardcode the methods and classes that need to have reflective access enabled, but it would be a mess to maintain. Instead, we have a custom Graal feature that discovers the needed classes and registers them for reflective access.