Modify the tests to run from the main app#29
Merged
Ostrzyciel merged 4 commits intomainfrom Mar 20, 2025
Merged
Conversation
Ostrzyciel
reviewed
Mar 20, 2025
| * @param args | ||
| * the command line arguments | ||
| */ | ||
| def runCommand(command: JellyCommand[?], args: List[String]): (String, String) = |
Member
There was a problem hiding this comment.
Why not put it in JellyCommand?
Then the call would be simpler. Instead of TestAppRunner.runCommand(RdfFromJelly, List(...))
You'd have RdfFromJelly.runTest(List(...))
Shorter.
Member
There was a problem hiding this comment.
You can keep the command name as part of the input List(), this does make sense.
Collaborator
Author
There was a problem hiding this comment.
Sure, makes sense. I think it makes the most sense to put as much of the input command in the argument lists in the test as possible - it will be easier to evaluate tests then.
Ostrzyciel
approved these changes
Mar 20, 2025
Member
Ostrzyciel
left a comment
Ostrzyciel
left a comment
There was a problem hiding this comment.
I have doubts about error handling, but we leave it for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #22