Merged
Conversation
Member
Author
|
Tested in AOT, it works |
Karolina-Bogacka
approved these changes
Apr 8, 2025
Collaborator
Karolina-Bogacka
left a comment
Karolina-Bogacka
left a comment
There was a problem hiding this comment.
Some small-ish comments, I like the generally large amount of tests here.
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfFromJelly.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfToJelly.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfValidate.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/MetricsPrinter.scala
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfValidate.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/util/jena/OrderedRdfCompare.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/util/jena/StreamRdfCollector.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/util/jena/StreamRdfCollector.scala
Outdated
Show resolved
Hide resolved
src/test/scala/eu/neverblink/jelly/cli/command/rdf/RdfValidateSpec.scala
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #66
I added some unit tests for the parsers and isomorphism checkers. The integration tests cover the rest.
Quite honestly, testing this properly would require 10x the amount of tests. I think we can defer that to Jelly-JVM and pyjelly using this command in their conformance test cases... let's not go overboard here.