This repository was archived by the owner on Feb 25, 2026. It is now read-only.
refactor mining speed retrieval to account for decimal speeds#110
Merged
anson-yeung merged 2 commits intoJellyLabScripts:masterfrom Jul 13, 2025
Merged
refactor mining speed retrieval to account for decimal speeds#110anson-yeung merged 2 commits intoJellyLabScripts:masterfrom
anson-yeung merged 2 commits intoJellyLabScripts:masterfrom
Conversation
Contributor
Author
|
copilot documentation 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
MiningSpeedRetrievalTaskfor better parsing of mining speed values and refines location checks in theGlacialMacro'sStartingState. The most important changes include the addition of regex-based parsing for mining speed, improved error handling, and updating location validation logic.Improvements to mining speed retrieval:
MINING_SPEED_PATTERNto extract numeric values (including decimals) from the "Mining Speed" string in the SkyBlock GUI. This replaces the previous approach of splitting strings, making the parsing more robust. (src/main/java/com/jelly/mightyminerv2/feature/impl/AutoGetStats/tasks/impl/MiningSpeedRetrievalTask.java, [1] [2]src/main/java/com/jelly/mightyminerv2/feature/impl/AutoGetStats/tasks/impl/MiningSpeedRetrievalTask.java, src/main/java/com/jelly/mightyminerv2/feature/impl/AutoGetStats/tasks/impl/MiningSpeedRetrievalTask.javaL51-R73)Refinements to location validation in
GlacialMacro:SubLocation.GLACITE_TUNNELSfrom the valid locations list, restricting checks toSubLocation.DWARVEN_BASE_CAMPfor better alignment with macro requirements. (src/main/java/com/jelly/mightyminerv2/macro/impl/GlacialMacro/states/StartingState.java, src/main/java/com/jelly/mightyminerv2/macro/impl/GlacialMacro/states/StartingState.javaL32-R32)src/main/java/com/jelly/mightyminerv2/macro/impl/GlacialMacro/states/StartingState.java, src/main/java/com/jelly/mightyminerv2/macro/impl/GlacialMacro/states/StartingState.javaL42-R41)