Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

refactor mining speed retrieval to account for decimal speeds#110

Merged
anson-yeung merged 2 commits intoJellyLabScripts:masterfrom
Jookly123:master
Jul 13, 2025
Merged

refactor mining speed retrieval to account for decimal speeds#110
anson-yeung merged 2 commits intoJellyLabScripts:masterfrom
Jookly123:master

Conversation

@Jookly123
Copy link
Copy Markdown
Contributor

This pull request introduces enhancements to the MiningSpeedRetrievalTask for better parsing of mining speed values and refines location checks in the GlacialMacro's StartingState. The most important changes include the addition of regex-based parsing for mining speed, improved error handling, and updating location validation logic.

Improvements to mining speed retrieval:

  • Regex-based parsing for mining speed: Introduced MINING_SPEED_PATTERN to extract numeric values (including decimals) from the "Mining Speed" string in the SkyBlock GUI. This replaces the previous approach of splitting strings, making the parsing more robust. (src/main/java/com/jelly/mightyminerv2/feature/impl/AutoGetStats/tasks/impl/MiningSpeedRetrievalTask.java, [1] [2]
  • Improved error handling: Enhanced error messages to include the problematic line and exception details when parsing fails, aiding debugging. (src/main/java/com/jelly/mightyminerv2/feature/impl/AutoGetStats/tasks/impl/MiningSpeedRetrievalTask.java, src/main/java/com/jelly/mightyminerv2/feature/impl/AutoGetStats/tasks/impl/MiningSpeedRetrievalTask.javaL51-R73)

Refinements to location validation in GlacialMacro:

@Jookly123
Copy link
Copy Markdown
Contributor Author

copilot documentation 🙏

@anson-yeung anson-yeung merged commit 72c65e2 into JellyLabScripts:master Jul 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants