Enrich composite_figi for 1,539 additional ISINs#125
Closed
AlfaStake wants to merge 1 commit into
Closed
Conversation
Added composite_figi identifiers to 13,004 rows (1,539 unique ISINs) previously missing this field, increasing coverage from 7,235 to 8,774 unique ISINs with composite_figi (from 80.7% to 97.9%). Methodology: - Extracted all unique ISINs lacking a composite_figi from equities.csv - Queried the OpenFIGI API (https://api.openfigi.com) using ISIN as the search key to obtain the corresponding composite FIGI identifiers - Mapped results back to all rows sharing the same ISIN Impact: - Only the composite_figi column was modified - No existing composite_figi values were overwritten or removed - No other columns were altered - Row count and order are unchanged (159,914 rows)
Owner
|
Unfortunately can not merge due to earlier PR, could you resolve? Then I'll merge it. |
Contributor
|
@JerBouma heads-up: this PR is no longer mergeable — it rewrote the entire I've re-applied only the genuine enrichment on top of current This one can be closed in favor of #150. |
JerBouma
pushed a commit
that referenced
this pull request
May 29, 2026
Two related data-quality resolutions: 1. composite_figi enrichment (adapts PR #125 to current main) - Fills empty composite_figi for 1,539 ISINs sourced via OpenFIGI, applied to 1,753 rows in equities.csv. Only previously-empty cells are populated; no existing value is overwritten and no other column is touched (coverage 7,235 -> 8,774 unique ISINs). 2. mic backfill + workflow fix (resolves PR #149 follow-up) - The Database-Update action did not set the new mic column for added tickers. build_new_ticker now derives exchange -> ISO 10383 MIC from the existing one-to-one data and fills it; unknown codes stay blank. - Backfills 16 NASDAQ rows (NMS -> XNAS) added by a prior run before the column existed. - Adds test_mic_filled_when_exchange_mapped: fails when a row has a known exchange but a missing mic (the gap that let those rows ship). Snapshot fixtures regenerated; full suite passes (58).
Owner
|
@AlfaStake Closed as completed in #150 alongside other improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composite_figiidentifiers to 13,004 rows (1,539 unique ISINs) that were previously missing this fieldcomposite_figicoverage from 7,235 → 8,774 unique ISINs (80.7% → 97.9%)composite_figicells were populatedMethodology
equities.csvthat lacked acomposite_figiValidation
composite_figicolumn modifiedcomposite_figivalues overwrittenBBG+ 9 alphanumeric chars format