Fix Config Language Setting Not Being Respected#269
Merged
JeremyDev87 merged 1 commit intomasterfrom Jan 19, 2026
Merged
Conversation
Remove hardcoded 'language': 'en' from 27 agent JSON files that was overriding the user's configured language in codingbuddy.config.js. Add DiagnosticLogService for file-based logging to help debug config loading issues. Logs are written to docs/codingbuddy/log/diagnostic.log. resolve #268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Config Language Setting Not Being Respected
Summary
"language": "en"from 27 agent JSON files to allow config-based language resolutionDiagnosticLogServicefor file-based logging to debug config loading issuesModeHandlerfor language resolution trackingChanges
1. Agent JSON Language Removal (27 files)
Removed the hardcoded
"language": "en"field from thecommunicationobject in all agent JSON files:Test Plan
diagnostic-log.service.spec.tshas 12 tests covering:Breaking Changes
None. The removal of
"language": "en"from agent JSON files is backward compatible because:mode.handler.ts:183has a fallback:const language = configLanguage || 'en'rules.service.ts:140-143overridescommunication.languagewith config value when availableDeployment Notes
After merging, rebuild and reinstall the MCP server to apply changes:
Then update Claude Code's MCP server configuration to use the rebuilt version.
Related Issues
resolve #268