Simplify Model Resolution from 4-Level to 2-Level Priority#300
Merged
JeremyDev87 merged 1 commit intomasterfrom Feb 3, 2026
Merged
Simplify Model Resolution from 4-Level to 2-Level Priority#300JeremyDev87 merged 1 commit intomasterfrom
JeremyDev87 merged 1 commit intomasterfrom
Conversation
BREAKING CHANGE: Model resolution now uses only global config and system default. Agent-level and mode-level model configurations are no longer supported. Changes: - Simplify ModelResolverService from 3 methods to 1 (resolve()) - Update ModelSource type to 'global' | 'system' only - Remove model field from all 30 agent JSON files - Deprecate ModelConfig interface (removal in v5.0.0) - Deprecate isModelConfig function (removal in v5.0.0) - Deprecate SYSTEM_DEFAULT_MODEL export (use DEFAULT_MODEL) - Fix tsconfig.json fixture causing test failure - Add explicit test for modelResolverService.resolve() call Migration: - Replace resolveForMode()/resolveForAgent() with resolve() - Move model preferences to codingbuddy.config.js - Replace SYSTEM_DEFAULT_MODEL with DEFAULT_MODEL close #299
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify Model Resolution from 4-Level to 2-Level Priority
Summary
This PR implements v4.0.0 breaking change that simplifies the model resolution priority system from 4 levels (Agent > Mode > Global > System) to 2 levels (Global > System).
Deprecation Notice
The following exports are deprecated and will be removed in v5.0.0:
ModelConfigmodel.types.tscodingbuddy.config.jsisModelConfig()model.types.tsSYSTEM_DEFAULT_MODELmodel.resolver.tsDEFAULT_MODELfrommodel.constants.tsTesting
Checklist
Related Issues
close #299