reflect SKILL_RECOMMENDED event in dashboard state (#474)#484
Merged
JeremyDev87 merged 1 commit intomasterfrom Feb 17, 2026
Merged
reflect SKILL_RECOMMENDED event in dashboard state (#474)#484JeremyDev87 merged 1 commit intomasterfrom
JeremyDev87 merged 1 commit intomasterfrom
Conversation
- Add activeSkills field to DashboardState - Handle SKILL_RECOMMENDED in reducer with deduplication - Reset activeSkills on MODE_CHANGED - Display active skills in FocusedAgentPanel between Objective and Checklist - Pass activeSkills prop through dashboard-app to FocusedAgentPanel - Replace no-op test with 3 behavior tests, add 2 UI tests
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activeSkills: string[]field toDashboardStateand handleSKILL_RECOMMENDEDevent in the reducer with deduplicationactiveSkillsonMODE_CHANGEDto clear stale skills when switching modesFocusedAgentPanelbetween Objective and Checklist sectionsCloses #474
Changes
dashboard-types.tsactiveSkills: string[]toDashboardStateuse-dashboard-state.tsSKILL_RECOMMENDEDhandler (deduplicated accumulation),MODE_CHANGEDresetuse-dashboard-state.spec.tsFocusedAgentPanel.tsxactiveSkillsprop, render Skills sectionFocusedAgentPanel.spec.tsxactiveSkillsprop to existing tests, add 2 new tests for Skills sectiondashboard-app.tsxactiveSkillsprop toFocusedAgentPanel(narrow + wide layouts)Test plan
SKILL_RECOMMENDEDaccumulatesactiveSkillsarrayMODE_CHANGEDresetsactiveSkillsto emptyactiveSkillsis emptytsc --noEmitclean