Skip to content

auto-inherit recommendedActAgent from context in ACT mode (#561)#575

Merged
JeremyDev87 merged 1 commit intomasterfrom
fix/561-act-mode-auto-inherit-recommended-agent
Feb 19, 2026
Merged

auto-inherit recommendedActAgent from context in ACT mode (#561)#575
JeremyDev87 merged 1 commit intomasterfrom
fix/561-act-mode-auto-inherit-recommended-agent

Conversation

@JeremyDev87
Copy link
Owner

Summary

Fixes #561

When the user types ACT, mode.handler.ts was calling keywordService.parseMode() before reading the context document. This meant the recommendedActAgent stored by the previous PLAN session was never passed to the agent resolver — it arrived too late.

Before (broken flow):

1. parseMode(prompt, options)   ← agent resolved here (no context)
2. handleContextDocument()      ← context read here (too late)

After (correct flow):

1. readContext()                ← extract recommendedActAgent
2. parseMode(prompt, options)   ← pass recommendedActAgent from context
3. handleContextDocument()

Changes

mode.handler.ts

  • Import LOCALIZED_KEYWORD_MAP to detect ACT keywords in all supported languages (EN/KO/JA/ZH/ES)
  • Pre-read context document before parseMode() when mode is ACT and no explicit recommended_agent param is provided
  • Extract recommendedActAgent from the last PLAN or AUTO section
  • Skip context read entirely when mode is not ACT (performance guard)

mode.handler.spec.ts

  • Add test: ACT mode auto-inherits recommendedActAgent from context when param not provided
  • Add test: Explicit recommended_agent param takes precedence over context value
  • Add test: readContext not called before parseMode when explicit param is provided (performance)
  • Add test: Korean ACT keyword (실행) triggers context inheritance
  • Add test: Spanish ACT keyword (ACTUAR) triggers context inheritance
  • Relocate "should not read context" test to PLAN mode describe block

Acceptance Criteria

  • ACT mode automatically uses recommendedActAgent from context document without explicit param
  • Explicit recommended_agent parameter still takes precedence over context value
  • No context read performed when mode is not ACT (performance)
  • Unit test: ACT after PLAN auto-inherits recommendation
  • Unit test: Explicit param overrides context recommendation
  • Localized ACT keywords (KO/ES) also trigger context inheritance

Test Results

✓ 3887 tests passed (2 skipped)
✓ tsc --noEmit — no type errors

…CT mode (#561)

Pre-read context document before parseMode() in ACT mode so that
the recommendedActAgent stored by the previous PLAN session is
automatically resolved as a fallback when no explicit
recommended_agent parameter is provided.

- Import LOCALIZED_KEYWORD_MAP to detect ACT keywords in all
  supported languages (EN/KO/JA/ZH/ES)
- Resolve recommendedActAgent from last PLAN/AUTO section before
  calling parseMode(), so agent resolver receives it in time
- Explicit recommended_agent parameter still takes precedence
- Skip context read entirely when mode is not ACT (performance)
@JeremyDev87 JeremyDev87 added bug Something isn't working fix sub-issue 상위 이슈의 하위 작업 mcp-server apps/mcp-server labels Feb 19, 2026
@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codingbuddy-landing Ready Ready Preview, Comment Feb 19, 2026 1:27am

@JeremyDev87 JeremyDev87 changed the title fix(mode-handler): auto-inherit recommendedActAgent from context in ACT mode (#561) auto-inherit recommendedActAgent from context in ACT mode (#561) Feb 19, 2026
@JeremyDev87 JeremyDev87 self-assigned this Feb 19, 2026
@JeremyDev87 JeremyDev87 merged commit 32264a0 into master Feb 19, 2026
25 checks passed
@JeremyDev87 JeremyDev87 deleted the fix/561-act-mode-auto-inherit-recommended-agent branch February 19, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fix mcp-server apps/mcp-server sub-issue 상위 이슈의 하위 작업

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(mode-handler): Auto-extract recommendedActAgent from context in ACT mode

1 participant