fix(mcp): improve SseAuthGuard timing-safe comparison#717
Merged
JeremyDev87 merged 2 commits intomasterfrom Mar 20, 2026
Merged
fix(mcp): improve SseAuthGuard timing-safe comparison#717JeremyDev87 merged 2 commits intomasterfrom
JeremyDev87 merged 2 commits intomasterfrom
Conversation
- Replace Buffer length check with HMAC-SHA256 hashing before timingSafeEqual - Eliminates token length timing side-channel leak - Add tests for different-length token rejection and HMAC hash properties Closes #704
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokensMatch()Buffer length early-return with HMAC-SHA256 hashing beforetimingSafeEqualTest plan
Closes #704