Skip to content

feat(skills): add receiving-code-review skill#848

Merged
JeremyDev87 merged 1 commit intomasterfrom
feat/receiving-code-review-skill-800
Mar 22, 2026
Merged

feat(skills): add receiving-code-review skill#848
JeremyDev87 merged 1 commit intomasterfrom
feat/receiving-code-review-skill-800

Conversation

@JeremyDev87
Copy link
Owner

Summary

  • Add new receiving-code-review skill at packages/rules/.ai-rules/skills/receiving-code-review/SKILL.md
  • Anti-sycophancy principle: enforce verification before implementing review feedback
  • Three-tier feedback classification: Must-Fix / Evaluate / Preference
  • Verification matrix mapping feedback types to concrete verification methods
  • 4-step disagreement protocol for constructive pushback
  • Response templates for all classification + outcome combinations
  • 9 documented anti-patterns with corrections
  • Edge case handling: conflicting reviews, vague feedback, framework-mandated code, test code
  • Complementary pair with existing pr-review skill (giving vs receiving)

Test plan

  • markdownlint passes (0 errors)
  • Skill follows v2.0 frontmatter format (name, description, allowed-tools, argument-hint)
  • Structure matches established skill pattern (Overview, Iron Law, When to Use, Phases, Red Flags)
  • No contradictions in Iron Law scoping (Preference items excluded from verification)
  • Code quality review: Critical 0, High 0, Medium 3 (all non-blocking)

Closes #800

- Anti-sycophancy principle: verify before implementing review feedback
- Feedback classification: Must-Fix / Evaluate / Preference
- Verification matrix with concrete methods per feedback type
- Disagreement protocol with 4-step escalation
- Response templates for all classification outcomes
- 9 anti-patterns documented with corrections

Closes #800
@vercel
Copy link

vercel bot commented Mar 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codingbuddy-landing Ready Ready Preview, Comment Mar 22, 2026 1:33am

@JeremyDev87 JeremyDev87 self-assigned this Mar 22, 2026
@JeremyDev87 JeremyDev87 merged commit d802d74 into master Mar 22, 2026
25 checks passed
@JeremyDev87 JeremyDev87 deleted the feat/receiving-code-review-skill-800 branch March 22, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(skills): add receiving-code-review skill

1 participant