#227: R8: Clean up unused parameters in post_processing.ts interfaces#245
Merged
JeremyDev87 merged 5 commits intomainfrom Feb 16, 2026
Merged
#227: R8: Clean up unused parameters in post_processing.ts interfaces#245JeremyDev87 merged 5 commits intomainfrom
JeremyDev87 merged 5 commits intomainfrom
Conversation
- Remove unused issueNumber field from FailureCommentParams interface - Update buildFailureComment call site in post_process_cli.ts - Update all test assertions in comment_builder.test.ts and post_process_cli.test.ts Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Create RescuePRTitleParams with only issueNumber, issueTitle, parentNumber - Create RescuePRBodyParams with all fields including language and runUrl - Update buildRescuePRTitle and buildRescuePRBody signatures Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove language and runUrl from buildRescuePRTitle call - Keep all fields in buildRescuePRBody call Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove language and runUrl from buildRescuePRTitle test calls in comment_builder.test.ts - Update post_process_cli.test.ts assertion to match new interface Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227
Summary
Cleaned up unused parameters from interfaces in
comment_builder.tsfollowing YAGNI principle:Removed
issueNumberfromFailureCommentParams— This field was never used bybuildFailureComment(). Updated the interface, call sites, and all tests.Split
RescuePRParamsinto two separate interfaces:RescuePRTitleParams— Only includes fields used bybuildRescuePRTitle()(issueNumber, issueTitle, parentNumber)RescuePRBodyParams— Includes all fields used bybuildRescuePRBody()(issueNumber, issueTitle, parentNumber, language, runUrl)Changes Made
src/comment_builder.tsinterfacessrc/post_process_cli.tscomment_builder.test.ts,post_process_cli.test.ts)Verification
✅ All tests pass (398 tests)
✅ Type checking passes
✅ Lint passes
✅ Build succeeds
✅ No behavior changes - all functions return the same values
🤖 Generated with Claude Code