Skip to content

Conversation

@ivan-pavlik
Copy link
Contributor

This PR adds user TSP webhook events (and thus completes Meetings webhooks block):

  • user.tsp_created
  • user.tsp_deleted
  • user.tsp_updated

Models:

  • UserTspAccount, DialInNumber, TspAccount (this can also be used in related API endpoints)
  • PhoneNumberType: new value added to enum
  • UserTspEvent: base class for user TSP webhook events
  • UserTspUpdatedEvent: additionally provides access to data from old_object property

WebhookEventConverter:

  • extracted switch by 'eventType' to a separate method that returns webhook event (this allows to avoid assigning 'webHookEvent' variable in each case, now we just return parsed event and assign method result to 'webHookEvent')
  • ParseChatMessageFileSentEvent, ParseChatMessageSentEvent, ParseWebinarRegistrationEvent, ParseRecordingProgressTimestamps: return updated event so that we could simply return method result from ParsePayloadToWebhookEvent

Unit tests:

  • updated user TSP webhooks data with all possible properties
  • adjusted some properties values to be able to reuse existing constants
  • introduced UserEmail constant and used it in existing tests
  • added missing unit test for 'endpoint.url_validation'

Copy link
Owner

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Jericho Jericho merged commit 4366d2a into Jericho:develop Nov 14, 2025
2 of 3 checks passed
@Jericho Jericho added the Enhancement New feature or request label Nov 14, 2025
@Jericho Jericho added this to the 0.99.0 milestone Nov 14, 2025
@ivan-pavlik ivan-pavlik deleted the feature/user_tsp_webhooks branch November 14, 2025 14:40
@Jericho
Copy link
Owner

Jericho commented Nov 14, 2025

🎉 This issue has been resolved in version 0.99.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants