Skip to content

Conversation

@ivan-pavlik
Copy link
Contributor

This PR adds the following webhook events:

  • phone.sms_campaign_number_opt_in
  • phone.sms_campaign_number_opt_out
  • phone.sms_etiquette_block
  • phone.sms_etiquette_warn
  • phone.sms_received
  • phone.sms_sent
  • phone.sms_sent_failed

Models:

  • PhoneSmsEvent: base model for all added events with AccountId property
  • again payload models used in sms webhooks are slightly different than models used in related sms API endpoints, so I've added base models with properties common for API endpoints and webhook events (SmsMessageBase, SmsParticipantBase, SmsOwnerBase), inherited existing models for API endpoints (SmsMessage, SmsHistoryParticipant, SmsParticipantOwner) and added webhook specific models (WebhookSmsMessage, WebhookSmsParticipant, WebhookSmsOwner).
  • SmsOptStatus, SmsOptInStatus - new enums
  • SmsCampaignNumbersOptStatus - used in webhook events and also can be used in related API endpoints
  • WebhookSmsCampaignOptStatuses - 'object' model used in sms campaign webhook events payload
  • WebhookSmsEtiquettePolicy - 'object' model used in sms etiquette webhook events payload

Unit tests:

  • added unit tests for the new webhook events
  • adjusted and aligned property values in phone sms webhook events json data to simplify checks

Copy link
Owner

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@Jericho Jericho added the Enhancement New feature or request label Nov 27, 2025
@Jericho Jericho added this to the 0.101.0 milestone Nov 27, 2025
@Jericho Jericho merged commit f970cf0 into Jericho:develop Nov 27, 2025
0 of 3 checks passed
@ivan-pavlik ivan-pavlik deleted the feature/phone_sms_webhooks branch November 27, 2025 14:21
@Jericho
Copy link
Owner

Jericho commented Nov 27, 2025

🎉 This issue has been resolved in version 0.101.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants