Merged
Conversation
JeremyTCD
force-pushed
the
fix-trycreatemessage-empty-data
branch
from
a112a07 to
8d1cb1b
Compare
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 97.82% 97.84% +0.02%
==========================================
Files 17 17
Lines 505 511 +6
==========================================
+ Hits 494 500 +6
Misses 11 11
Continue to review full report at Codecov.
|
JeremyTCD
force-pushed
the
fix-trycreatemessage-empty-data
branch
from
b8729de to
eedf56a
Compare
- We can't just ignore data if its length is 0. If JS calls console.log('a\n\nb'), we receive "a", "" and "b", where "" denotes an empty line between "a" and "b".
JeremyTCD
force-pushed
the
fix-trycreatemessage-empty-data
branch
from
eedf56a to
5216236
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#54