Don't overwrite NodeJSProcessOptions#71
Merged
JeremyTCD merged 7 commits intoJeringTech:masterfrom Feb 12, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 97.48% 97.52% +0.03%
==========================================
Files 18 18
Lines 557 565 +8
==========================================
+ Hits 543 551 +8
Misses 14 14
Continue to review full report at Codecov.
|
Member
|
This is an excellent find. Shouldn't have been overwriting user specified options. Please add your name and link to the ReadMe contributor section. Will merge and release 5.3.1 after updating/adding unit tests. |
JeremyTCD
changed the title
Member
|
Am working on the unit tests now, don't worry about them. |
Member
|
Released 5.3.1 🚀. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.