fix(tests): increase timeout margin in Timeout_FallbackToDefault_UsesDefaultWhenExceeded#72
Merged
JerrettDavis merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
…DefaultWhenExceeded The 100ms timeout was too tight for CI runners under load (1852 tests running concurrently with Docker containers). SuccessService's Task.Delay(10) occasionally exceeded the 100ms budget, causing the fallback trial to also time out and the test to fail spuriously. Increasing to 2000ms still reliably times out SlowService (5000ms) while giving the SuccessService fallback ample margin on loaded CI workers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Code Coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage ? 83.42%
=======================================
Files ? 194
Lines ? 7036
Branches ? 996
=======================================
Hits ? 5870
Misses ? 1166
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The Timeout_FallbackToDefault_UsesDefaultWhenExceeded test was failing intermittently on CI due to tight timing.
The test used a 100ms timeout with SuccessService containing �wait Task.Delay(10). Under CI load (1,852 tests + Docker container tests running concurrently), Task.Delay(10) occasionally exceeded the 100ms budget, causing the fallback trial itself to also timeout and the test to fail spuriously.
Error seen:
System.TimeoutException : Trial '' for ITestService.ExecuteAsync exceeded timeout of 100msFix
Increased the timeout from 100ms → 2000ms. This still reliably times out SlowService (which has a 5000ms delay) while giving the SuccessService fallback (10ms delay) a 200× margin on loaded CI workers.
Validation