test: phase 3 coverage push (Dashboard.UI deep tests + Api error paths + CI fix)#89
Merged
JerrettDavis merged 3 commits intomainfrom Apr 24, 2026
Merged
test: phase 3 coverage push (Dashboard.UI deep tests + Api error paths + CI fix)#89JerrettDavis merged 3 commits intomainfrom
JerrettDavis merged 3 commits intomainfrom
Conversation
…rage pr-checks and e2e-tests jobs previously only fired on pull_request events. Merge commits therefore only got coverage from the release job (unit tests, no E2E), causing an ~8-point Codecov drop on every merge (74% PR → 66% main). - Broaden pr-checks trigger: pull_request | push to main - Broaden e2e-tests trigger: pull_request | push to main - Guard the sticky PR comment step with if: github.event_name == 'pull_request' so it doesn't fail on push events (no PR context available) - codecov.yml already has carryforward: true for both flags — no change needed Post-merge main CI will now upload both unittests + e2e flags, matching the PR-branch coverage number. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…dModel unit tests Track A — Dashboard.UI deep coverage: - ExperimentApiClientTests (60 tests): full HTTP method coverage via MockHandler; covers all 20+ methods including error paths, null responses, HttpRequestException handling, and all governance/plugin/DSL paths - ExperimentCodeGeneratorTests (34 tests): all SelectionModeType and ErrorPolicyType branches for both GenerateYaml and GenerateFluentApi; special-char escaping, empty/null description handling, multi-variant output - ExperimentWizardModelTests (37 tests): ValidateStep1/2/3 for every validation branch (invalid name format, kebab-case variants, duplicate keys, each selection mode, each error policy); Reset() verification; default state assertions Total new tests in Dashboard.UI.Tests: +131 (198 total, was 71 bUnit + 16 services) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r tests
Track B — Dashboard.Api deep coverage:
- DashboardApiErrorPathTests (63 new tests): covers every endpoint group with:
- Error paths: 503 on missing rollout backplane, 501 on missing plugin/targeting
service, 400 on invalid DSL/variant inputs, 404 on missing resources
- Response shape assertions: JSON schema validation via JsonDocument.Parse
- Mock-provider paths: analytics statistics, export (JSON + CSV), usage stats,
targeting rules/evaluate, plugin list/discover, rollout config with backplane
- Content-type consistency: governance, approvals, kill-switch endpoints
- DashboardApiTestHost: extended constructor to accept IRolloutPersistenceBackplane,
IAnalyticsProvider, ITargetingManagementService, IPluginManagementService
Total new tests in Dashboard.Api.Tests: +63 (85 total, was 22)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Code Coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
===========================================
+ Coverage 66.19% 77.05% +10.86%
===========================================
Files 250 250
Lines 9888 9888
Branches 1634 1397 -237
===========================================
+ Hits 6545 7619 +1074
+ Misses 2989 2269 -720
+ Partials 354 0 -354
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExperimentApiClient(60 tests),ExperimentCodeGenerator(34 tests), andExperimentWizardModel(37 tests). Total Dashboard.UI.Tests: 198 (was 87). Estimated assembly lift: 7.3% → ~55-65%.pr-checksande2e-testsjobs now also run on push tomain, so bothunittestsande2eCodecov flags upload on every merge. Previously main-branch Codecov dropped ~8 points vs PR-branch on every merge. Sticky PR comment guarded withif: github.event_name == 'pull_request'.Per-assembly estimates (based on SUT analysis)
Test plan
dotnet test ExperimentFramework.Dashboard.UI.Tests— 198 passed, 0 faileddotnet test ExperimentFramework.Dashboard.Api.Tests— 85 passed, 0 failed[Fact(Skip=...)]— all tests are active and assert real behavior🤖 Generated with Claude Code