docs: further tweaked docs building and publishing to fix warnings.#5
Merged
JerrettDavis merged 1 commit intomainfrom Sep 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses documentation build warnings by making several targeted fixes to improve XML documentation generation and remove problematic references.
- Updated project configuration to enable documentation file generation
- Fixed XML documentation reference warnings by updating method references to valid API paths
- Removed unused code and documentation that was causing build issues
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/PatternKit.Generators.Abstractions/PatternKit.Generators.Abstractions.csproj | Added documentation generation properties to fix build warnings |
| src/PatternKit.Examples/Chain/AuthLoggingDemo.cs | Fixed XML documentation references and removed unused HttpResponse struct |
| test/PatternKit.Tests/Creational/Builder/BranchBuilderTests.cs | Improved test assertions using xUnit's Assert.Single method |
| docs/index.md | Removed broken cross-references and updated table formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Code Coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 85.17% 89.85% +4.67%
==========================================
Files 22 22
Lines 1302 1301 -1
Branches 153 153
==========================================
+ Hits 1109 1169 +60
+ Misses 152 132 -20
+ Partials 41 0 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JerrettDavis
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.