test: improve generator coverage#500
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases unit test coverage for the source generators—specifically expanding scenario coverage for the CompensatingTransactionGenerator and DecoratorGenerator to exercise additional edge cases (type shapes/accessibility and emitted literal/name escaping).
Changes:
- Added DecoratorGenerator tests for inaccessible protected members and for preserving additional default literal forms (nullable/default/null, enum named defaults, floating-point special values).
- Added CompensatingTransactionGenerator tests covering additional host type shapes/accessibilities and string escaping in generated output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/PatternKit.Generators.Tests/DecoratorGeneratorTests.cs | Adds scenarios for PKDEC004 (inaccessible protected property) and expands literal/default-value emission assertions. |
| test/PatternKit.Generators.Tests/CompensatingTransactionGeneratorTests.cs | Adds scenarios validating generation across multiple host shapes/accessibilities and escaped names in emitted code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Test Results 12 files 12 suites 12m 20s ⏱️ Results for commit f1cee65. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
+ Coverage 97.40% 97.44% +0.03%
==========================================
Files 611 611
Lines 49926 49926
Branches 3230 34 -3196
==========================================
+ Hits 48631 48650 +19
+ Misses 1295 1276 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
JerrettDavis
force-pushed
the
feature/source-generator-coverage-413
branch
from
e38fb20 to
f1cee65
Compare
Contributor
Code Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #413
Summary
Local coverage delta
Validation