fix(fileprovider): fix EDEADLK hydration deadlock + CLI pull prefix#73
Merged
Jesssullivan merged 2 commits intomainfrom Mar 10, 2026
Merged
fix(fileprovider): fix EDEADLK hydration deadlock + CLI pull prefix#73Jesssullivan merged 2 commits intomainfrom
Jesssullivan merged 2 commits intomainfrom
Conversation
The Swift FileProvider extension calls tcfs_provider_enumerate_changes() but cbindgen was not exporting TcfsChangeEvent, causing the function declaration to be omitted from the generated header. This resulted in an undefined symbol linker error on aarch64-darwin.
…LK hydration
item(for:) was returning downloaded=true (default), which told fileproviderd
the content was already materialized locally. When Finder tried to read the
file, it got EDEADLK because no local content existed.
Also fixes CLI pull prefix derivation for multi-segment prefixes like
devices/A29247 — rsplit_once("/manifests/") instead of split("/").next().
Jesssullivan
added a commit
to tinyland-inc/tummycrypt
that referenced
this pull request
Apr 8, 2026
…esssullivan#73) * fix(fileprovider): add TcfsChangeEvent to cbindgen exports The Swift FileProvider extension calls tcfs_provider_enumerate_changes() but cbindgen was not exporting TcfsChangeEvent, causing the function declaration to be omitted from the generated header. This resulted in an undefined symbol linker error on aarch64-darwin. * fix(fileprovider): return downloaded=false in item(for:) to fix EDEADLK hydration item(for:) was returning downloaded=true (default), which told fileproviderd the content was already materialized locally. When Finder tried to read the file, it got EDEADLK because no local content existed. Also fixes CLI pull prefix derivation for multi-segment prefixes like devices/A29247 — rsplit_once("/manifests/") instead of split("/").next().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
item(for:)was returningdownloaded: true(default), telling fileproviderd content was already local. Finder read attempts gotEDEADLKbecause no local content existed. Fix: returndownloaded: falsefor non-root items.pullprefix derivation usedsplit('/').next()which only took the first segment. For multi-segment prefixes likedevices/A29247/manifests/<hash>, this gavedevicesinstead ofdevices/A29247. Fix: usersplit_once("/manifests/").Test plan
--prefix devices/<id>, pull via CLI — chunks found correctlyfetchContentsinstead of EDEADLK