feat: single video endpoint#361
Merged
Merged
Conversation
…susFilm/core into 22-02-TN-chore-add-videos-api
…/JesusFilm/core into 22-02-TN-chore-add-languages-api
|
This pull request is being automatically deployed with Vercel (learn more). journeys – ./🔍 Inspect: https://vercel.com/jesusfilm/journeys/GVDmDG11EHHqxsv1ipa2xxPWRkj7 [Deployment for ebf611d canceled] journeys-admin – ./🔍 Inspect: https://vercel.com/jesusfilm/journeys-admin/4vBgigroDqP5d8PQNyMpsZVu7Quf [Deployment for d97cc93 canceled] |
GeronimoJohn
added
effort: 2
priority: now
type: feat
Contributor
|
tataihono
previously requested changes
Mar 17, 2022
tataihono
previously requested changes
Mar 17, 2022
tataihono
approved these changes
Mar 17, 2022
GeronimoJohn
added a commit
that referenced
this pull request
Mar 17, 2022
fix: inline editing fab (#324) * feat: update add fab to support edit * feat: change to edit fab on typography click * fix: refine changes * fix: type-check * fix: storybook config feature: Add toggle lock status to Step (#312) * feat: created the component * chore: adjusted styling for the drawer * feat: added styling for component * feat: connected backend to changing lock status * fix: add locked prop to optimistic response * chore: adjusted text color * feat: add stories to Conditions * feat: test for Conditions * refactor: renamed to LockStep * feat: added stories for NextCard, change naming * refactor: changed lock step to be a generic component * refactor: changed NextCard to use ToggleOption * refactor: changed to obtaing selectedBlock so cache can be updated * test: updated stories * test: added tests * fix: minor changes from PR review chore: create api-languages feat: fetch data from arclight api chore: add videos api chore: match translation object feat: add download links feat: add study questions to video chore: change seeder to match new format fix: fulltext title search feat: implement language module refactor: language and translation module chore: add language and title filters feat: add tagIds feat: created video object fix: language getAll logic chore: add arclight api key env chore: refactor seed chore: add translation field decorator feat: refactor video object and added filterAll feature: background video (#322) * feat: delete block api * fix: missing keyasid decorator * feat: background image initial commit * fix: typo in graphql * feat: background media image * feat: background media video change src update method * feat: background video update specs will need to revisit design changes * feat: background media image * fix: image block creation & specs * fix: remove dead method in spec * fix: drawer click dispatch props * fix: missing new property from merge * feat: background media story update * chore: update storybook and add interactions * fix: casting error * feat: update stories * fix: bad import and breakpoints * feat: update stories and video src design * feat: add formik * feat: validation * feat: validation specs * fix: remove unused npm package * feat: validation * feat: validation specs * feat: formik * feat: formik * feat: swap to onblur * fix: extra import * fix: failing validation test * feat: add formik * fix: style update * feat: togglebutton default * fix: toggle spacing * fix: remove dead import * feat: formik specs * feat: validation * fix: styling * fix: styling & simplified * fix: styles * fix: disable validation test * fix: merge changes * fix: codegen * fix: placeholder color * chore: story template, pr requests * feat: refactor for re-use * feat: refactor for re-use * fix: remove dead imports * feat: breakpoints * fix: pr requests * feat: editor stories * fix: story lint * fix: lint feature: edit icons (#326) * feat: edit button icon * fix: updated component logic with new backend * feat: added in mutations for adding switching and deleting icons on button * feat: added optimistic response for icon name * test: added tests * test: stories for icon name * chore: removed comments * feat: updated naming on the attribute button, updated tests * feat: mutations for icon color * test: tests for icon color mutations * test: updated stories for icon color * feat: mutations for icon size * test: added test and stories for icon size * chore: added comments for bugs * refactor: updated icon with new API changes * test: fixed stories * test: fixed test for api update * refactor: simplified components * fix: front end now reflect icons being updated * fix: fixed stories * refactor: moved the entire component * chore: updated storybook paths * feat: added extra size option for icon * fix: fix test * fix: updated condition to compare off state so icons can correctly change * chore: removed redundant changes * fix: fix broken tests * refactor: renamed component + minor naming adjustments * refactor: removed react hooks in favour of using apollo cache * test: updated tests from refactor * revert: removed size option due to Mui Button contraints * fix: updaated path for color story * chore: ran codegen * test: removed tests for size * fix: simply types/interfaces * fix: type-check * fix: revert width height to fontSize Co-authored-by: Ziwei Liu <ziwei.liu.23@gmail.com> fix: blockDelete (#331) * fix: blockDelete * fix: remove console.log * fix: update schema * fix: lint fix: switch back to edit fab when selecting another block (#333) * fix: switch back to edit fab when selecting another block * fix: remove console.log * fix: video and image switches back to Add fab feature: edit signup icon (#330) * feat: implemented icon edit for signUp * test: added test * fix: typo * fix: tidied data for Editor stories, added Iconblock to signUp button in data feature: InlineEditWrapper and TypographyEdit component (#328) * fix: card auto margin squash text field * fix: render new line characters * fix: conductor story data, used to check card auto margins * fix: export WrappersProps * fix: export WrapperProps * feat: create TypographyEdit component * feat: create InlineEdit component wrapper * fix: linting * fix: align and color styling for TypographyEdit fix: updated test to propery test drawer is opening (#337) feature: edit button actions (#317) * feat: edit actions on button * feat: front end defaults to no action * fix: broken as, showing ziwei * fix: add field validation * feat: added submit to linkAction form * fix: fixed break tests due to change from Icon * chore: updated icon data shape for specs and stories * chore: remove comments * chore: added comment for future todo * fix: disabled normalization of action in cache, store action data in parentBlock * feat: added mutation for link action * feat: added remove action mutation * fix: updated tests * feat: added test for remove action * fix: updated stories * fix: corrected parent blockId * chore: refactored enum for actions into object * chore: removed comments * chore: refactored test data * chore: clean up * test: added tests for validation on link action * refactor: renamed actionRemove to actionDelete * test: added tests for cache updates * fix: updated cache tests to check cache is updating correctly * fix: updated incorrect id * feat: added start icon for url input * fix: update key to use id for uniqueness * chore: renamed aria label as according to aria docs for labelless inputs * refactor: updated structure for stories * fix: added back selectedBlock for mock responses * feat: added label, removed placeholder text * refactor: action story renders in drawer * test: updated tests formating" * fix: remove typo * fix: made updates suggested on PR * feat: added helper text * refactor: updated component to disable Next step option if no next step * test: updated stories for disabled option * test: added test for disabled menu option * chore: slight name change to a test * chore: updated naming to follow design updated * fix: fix bug with storybook not finding button * style: adjusted alignments * test: added aditional stories Co-authored-by: Ziwei Liu <ziwei.liu.23@gmail.com> chore: change lint syntax fix: nest decorator lint fix: languageId should be id fix: pr feedback chore: remove .env file fix: remove invalid nulls feature: background media poster image (#329) * feat: delete block api * fix: missing keyasid decorator * feat: background image initial commit * fix: typo in graphql * feat: background media image * feat: background media video change src update method * feat: background video update specs will need to revisit design changes * feat: background media image * fix: image block creation & specs * fix: remove dead method in spec * fix: drawer click dispatch props * fix: missing new property from merge * feat: background media story update * chore: update storybook and add interactions * fix: casting error * feat: update stories * fix: bad import and breakpoints * feat: update stories and video src design * feat: add formik * feat: validation * feat: validation specs * fix: remove unused npm package * feat: validation * feat: validation specs * feat: background video poster * feat: formik * feat: formik * feat: swap to onblur * fix: extra import * fix: failing validation test * feat: add formik * fix: style update * feat: togglebutton default * fix: toggle spacing * fix: remove dead import * feat: formik specs * feat: validation * fix: styling * fix: styling & simplified * fix: styles * feat: media bg poster * fix: disable validation test * fix: merge changes * fix: codegen * fix: placeholder color * chore: story template, pr requests * feat: refactor for re-use * feat: refactor for re-use * fix: remove dead imports * feat: breakpoints * fix: pr requests * feat: editor stories * fix: story lint * feat: image editor * fix: lint * feat: image editor * feat: poster editor * feat: stories * fix: test * fix: lint * fix: viewports * fix: breakpoints and padding * fix: lint * fix: missing modal story * fix: pr changes * fix: update poster for blockdelete * fix: lint * feat: modal to dialog * fix: pr requests * fix: vlad feedback * fix: styles feature: Actions edit, signUp (#336) * feat: edit actions on button * feat: front end defaults to no action * fix: broken as, showing ziwei * fix: add field validation * feat: added submit to linkAction form * fix: fixed break tests due to change from Icon * chore: updated icon data shape for specs and stories * chore: remove comments * chore: added comment for future todo * fix: disabled normalization of action in cache, store action data in parentBlock * feat: added mutation for link action * feat: added remove action mutation * fix: updated tests * feat: added test for remove action * fix: updated stories * fix: corrected parent blockId * chore: refactored enum for actions into object * chore: removed comments * chore: refactored test data * chore: clean up * test: added tests for validation on link action * refactor: renamed actionRemove to actionDelete * test: added tests for cache updates * fix: updated cache tests to check cache is updating correctly * fix: updated incorrect id * feat: added start icon for url input * fix: update key to use id for uniqueness * chore: renamed aria label as according to aria docs for labelless inputs * refactor: updated structure for stories * fix: added back selectedBlock for mock responses * feat: added label, removed placeholder text * refactor: action story renders in drawer * test: updated tests formating" * fix: remove typo * fix: made updates suggested on PR * feat: added helper text * refactor: updated component to disable Next step option if no next step * test: updated stories for disabled option * test: added test for disabled menu option * chore: slight name change to a test * chore: updated naming to follow design updated * fix: fix bug with storybook not finding button * style: adjusted alignments * test: added aditional stories * feat: added actions edit to signUp Co-authored-by: Ziwei Liu <ziwei.liu.23@gmail.com> feature: inline edit button (#339) * fix: card auto margin squash text field * fix: render new line characters * fix: conductor story data, used to check card auto margins * fix: export WrappersProps * fix: export WrapperProps * feat: create TypographyEdit component * feat: create InlineEdit component wrapper * fix: linting * fix: align and color styling for TypographyEdit * feat: create ButtonEdit component * fix: remove whitespace in button label * fix: add InlineEditWrapper test * fix: minHeight for all button sizes feature: create api-languages (#340) Co-authored-by: John Geronimo <johnageronimo1@gmail.com> fix: simplify video type naming refactor: updated videos object to match api chore: generate graphql chore: generate graphql api-languages feat: add translation resolver revert: remove unecessary change test: video resolver and service tests feature: Actions edit, radioOption (#335) * feat: edit actions on button * feat: front end defaults to no action * fix: broken as, showing ziwei * fix: add field validation * feat: added submit to linkAction form * fix: fixed break tests due to change from Icon * chore: updated icon data shape for specs and stories * chore: remove comments * chore: added comment for future todo * fix: disabled normalization of action in cache, store action data in parentBlock * feat: added mutation for link action * feat: added remove action mutation * fix: updated tests * feat: added test for remove action * fix: updated stories * fix: corrected parent blockId * chore: refactored enum for actions into object * chore: removed comments * chore: refactored test data * chore: clean up * test: added tests for validation on link action * refactor: renamed actionRemove to actionDelete * test: added tests for cache updates * fix: updated cache tests to check cache is updating correctly * fix: updated incorrect id * feat: added start icon for url input * fix: update key to use id for uniqueness * chore: renamed aria label as according to aria docs for labelless inputs * refactor: updated structure for stories * fix: added back selectedBlock for mock responses * feat: added label, removed placeholder text * refactor: action story renders in drawer * test: updated tests formating" * fix: remove typo * fix: made updates suggested on PR * feat: added helper text * refactor: updated component to disable Next step option if no next step * test: updated stories for disabled option * test: added test for disabled menu option * chore: slight name change to a test * chore: updated naming to follow design updated * fix: fix bug with storybook not finding button * style: adjusted alignments * test: added aditional stories * feat: added action edit to radio option * fix: updated test to correctly test drawer is opening * refactor: updated how drawer opening is tested * refactor: adjusted styling for cards displayed * refactor: removed negative margin * chore: remove unused import Co-authored-by: Ziwei Liu <ziwei.liu.23@gmail.com> feature: image block edit (#345) * feat: delete block api * fix: missing keyasid decorator * feat: background image initial commit * fix: typo in graphql * feat: background media image * feat: background media video change src update method * feat: background video update specs will need to revisit design changes * feat: background media image * fix: image block creation & specs * fix: remove dead method in spec * fix: drawer click dispatch props * fix: missing new property from merge * feat: background media story update * chore: update storybook and add interactions * fix: casting error * feat: update stories * fix: bad import and breakpoints * feat: update stories and video src design * feat: add formik * feat: validation * feat: validation specs * fix: remove unused npm package * feat: validation * feat: validation specs * feat: background video poster * feat: formik * feat: formik * feat: swap to onblur * fix: extra import * fix: failing validation test * feat: add formik * fix: style update * feat: togglebutton default * fix: toggle spacing * fix: remove dead import * feat: formik specs * feat: validation * fix: styling * fix: styling & simplified * fix: styles * feat: media bg poster * fix: disable validation test * fix: merge changes * fix: codegen * fix: placeholder color * chore: story template, pr requests * feat: refactor for re-use * feat: refactor for re-use * fix: remove dead imports * feat: breakpoints * fix: pr requests * feat: editor stories * fix: story lint * feat: image editor * fix: lint * feat: image editor * feat: poster editor * feat: stories * fix: test * fix: lint * fix: viewports * fix: breakpoints and padding * fix: lint * fix: missing modal story * fix: pr changes * fix: update poster for blockdelete * fix: lint * feat: modal to dialog * fix: pr requests * fix: vlad feedback * fix: styles * feat: image block * feat: image block * feat: image edit * fix: typo fix: filter parent order null (#350) * fix: updated test to propery test drawer is opening * fix: added filter + tests feature: add SignUp inline editing (#334) * fix: card auto margin squash text field * fix: render new line characters * fix: conductor story data, used to check card auto margins * fix: export WrappersProps * fix: export WrapperProps * feat: create TypographyEdit component * feat: create InlineEdit component wrapper * fix: linting * fix: align and color styling for TypographyEdit * feat: create ButtonEdit component * fix: remove whitespace in button label * fix: add InlineEditWrapper test * feat: add SignUp submit label inline editing * fix: remove static min-height from button * fix: sign up tests feature: set next card (#347) * feat: refactor locked step * feat: create next cards component * fix: type-check on cards and conditions * fix: fix styling * feat: create selected card display * fix: update next card drawer * fix: tests, show drawer on last card * fix: add missing stories * fix: type-check * fix: vlad feedback, update story data feature: video block (#344) * feat: video block * fix: switch condition * fix: pr change fix: blockDelete null parentBlockId (#352) style: match commitlint, pr branch and title (#355) fix: spelling mistake on describe test: add additional resolver specs feat: add getVideo Query revert: remove single video endpoint fix: Center selected card on Horizontal Select (#356) * fix: simple Horizontal Select centering selected card * fix: mock out scroll feat: create api-videos (#348) Co-authored-by: John Geronimo <johnageronimo1@gmail.com> Co-authored-by: Mike Allison <mike@captainofbass.com> ci: add arclight api key (#358) ci: split danger into its own workflow (#359) fix: languages endpoint needs platform parameter (#362) chore: add dependabot config (#289) feat: language filter drawer for video library (#323) Co-authored-by: John Geronimo <johnageronimo1@gmail.com> fix: journeys-admin linting (#367) fix: github action conditionals (#368) Co-authored-by: Tataihono Nikora <tataihono.nikora@gmail.com> feat: single video endpoint (#361) * chore: create api-languages * feat: fetch data from arclight api * chore: add videos api * chore: match translation object * feat: add download links * feat: add study questions to video * feat: implement language module * chore: change seeder to match new format * fix: fulltext title search * refactor: language and translation module * chore: add language and title filters * feat: add tagIds * feat: created video object * fix: language getAll logic * chore: add arclight api key env * chore: refactor seed * chore: add translation field decorator * chore: change lint syntax * fix: nest decorator lint * feat: refactor video object and added filterAll * fix: languageId should be id * fix: pr feedback * chore: remove .env file * fix: remove invalid nulls * fix: simplify video type naming * chore: generate graphql * chore: generate graphql api-languages * feat: add translation resolver * revert: remove unecessary change * test: video resolver and service tests * fix: spelling mistake on describe * test: add additional resolver specs * feat: add getVideo Query * revert: remove single video endpoint * feat: single video endpoint * test: add getVideo test * fix: made variantLanguageId optional in getVideo * fix: minor refactor for test Co-authored-by: Tataihono Nikora <tataihono.nikora@gmail.com> feat: add getvideo mutation to videodetails ci: danger to check existing reviews too (#369) fix: version lock winston-cloudwatch (#370) fix: supergraph endpoint (#371) * fix: supergraph endpoint * fix: http fix: disable background video autoplay & mute (#353) * fix: disable background video autoplay & mute * fix: pr change request chore: fix test case warnings (#357) ci: danger to check existing reviews too (#369) fix: version lock winston-cloudwatch (#370) fix: supergraph endpoint (#371) * fix: supergraph endpoint * fix: http fix: disable background video autoplay & mute (#353) * fix: disable background video autoplay & mute * fix: pr change request chore: fix test case warnings (#357) fix: add bottom margin to radio question (#364) * fix: add bottom margin to radio question * fix: update test * fix: update import Co-authored-by: Siyang <csiyang@yahoo.co.nz> chore: update nest apollo (#354) * chore: update nestjs and apollo this will allow for graphql uploads in the future * fix: update languages * chore: api-video
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a single video endpoint
How should this PR be QA Tested?
Please describe the QA tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Checklist