chore: move apis to api folder #5120
Conversation
WalkthroughThis pull request systematically updates file and directory paths throughout the repository. Changes replace the old "apps/..." prefixes with "apis/..." in workflow configurations, Dockerfiles, configuration files, and project-related JSON, TypeScript, ESLint, Jest, and code generation files. The updates ensure that all references—whether for retrieving affected applications, building Docker images, testing, linting, or generating schemas—accurately reflect the new directory structure without altering any underlying functionality. Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (30)
✅ Files skipped from review due to trivial changes (17)
🚧 Files skipped from review as they are similar to previous changes (6)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🔇 Additional comments (22)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
💰 Infracost reportMonthly estimate generatedThis comment will be updated when code changes. |
github-actions
bot
had a problem deploying
to
Preview - journeys-admin
|
Ran Plan for dir: Show OutputTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.datadog.module.datadog_log_forwarder.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "datadog-log-forwarder"
tags = {
"DD_FORWARDER_VERSION" = "3.73.0"
}
# (30 unchanged attributes hidden)
~ environment {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ variables = (sensitive value)
}
# (2 unchanged blocks hidden)
}
# module.datadog.module.datadog_rds_enhanced_monitoring_forwarder.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "datadog-rds-enhanced-monitoring-forwarder"
tags = {
"DD_FORWARDER_VERSION" = "3.73.0"
}
# (28 unchanged attributes hidden)
~ environment {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ variables = (sensitive value)
}
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
Plan: 0 to add, 2 to change, 0 to destroy.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
api/analytics/project.json (1)
108-112: Review Codecov Command Tag
The Codecov command on line 111 uses the flag-F apps.api-analytics. Given the new structure, consider updating this flag to better reflect the project’s current naming (e.g.-F api-analytics) unless there’s a specific reason to retain the old tag.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (12)
api/analytics/src/__generated__/graphql-env.d.tsis excluded by!**/__generated__/**api/analytics/src/__generated__/pothos-types.tsis excluded by!**/__generated__/**api/journeys-modern/db/ERD.svgis excluded by!**/*.svgapi/journeys-modern/src/__generated__/graphql-env.d.tsis excluded by!**/__generated__/**api/journeys-modern/src/__generated__/pothos-types.tsis excluded by!**/__generated__/**api/journeys/db/ERD.svgis excluded by!**/*.svgapi/journeys/src/__generated__/fragment-masking.tsis excluded by!**/__generated__/**api/journeys/src/__generated__/gql.tsis excluded by!**/__generated__/**api/journeys/src/__generated__/graphql.tsis excluded by!**/__generated__/**api/journeys/src/__generated__/index.tsis excluded by!**/__generated__/**api/journeys/src/app/__generated__/graphql.tsis excluded by!**/__generated__/**api/journeys/src/app/lib/casl/__generated__/prismaSubjects.tsis excluded by!**/__generated__/**
📒 Files selected for processing (30)
.github/workflows/api-deploy-worker.yml(1 hunks).github/workflows/api-gateway-prod-worker.yml(2 hunks).github/workflows/api-gateway-stage-worker.yml(2 hunks).gitignore(1 hunks).prettierignore(1 hunks).storybook/main.ts(1 hunks)api/analytics/Dockerfile(1 hunks)api/analytics/codegen.ts(1 hunks)api/analytics/eslint.config.js(1 hunks)api/analytics/jest.config.ts(1 hunks)api/analytics/project.json(3 hunks)api/analytics/src/schema/generate.ts(1 hunks)api/analytics/tsconfig.json(1 hunks)api/gateway/Dockerfile(1 hunks)api/gateway/eslint.config.js(1 hunks)api/gateway/gateway.config.ts(1 hunks)api/gateway/project.json(2 hunks)api/journeys-modern/Dockerfile(1 hunks)api/journeys-modern/eslint.config.js(2 hunks)api/journeys-modern/jest.config.ts(1 hunks)api/journeys-modern/project.json(4 hunks)api/journeys-modern/src/schema/generate.ts(1 hunks)api/journeys-modern/tsconfig.json(1 hunks)api/journeys/Dockerfile(1 hunks)api/journeys/codegen.ts(1 hunks)api/journeys/eslint.config.js(2 hunks)api/journeys/jest.config.ts(1 hunks)api/journeys/project.json(6 hunks)api/journeys/src/app/app.module.ts(1 hunks)api/journeys/src/app/lib/casl/caslPrismaGenerator.ts(1 hunks)
✅ Files skipped from review due to trivial changes (11)
- api/journeys/src/app/lib/casl/caslPrismaGenerator.ts
- api/journeys/jest.config.ts
- .gitignore
- api/gateway/gateway.config.ts
- api/gateway/eslint.config.js
- api/analytics/tsconfig.json
- api/analytics/src/schema/generate.ts
- api/journeys-modern/jest.config.ts
- .prettierignore
- api/journeys-modern/project.json
- api/journeys-modern/tsconfig.json
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: Deploy Preview and Test (watch, 5120/merge, pull_request, 20)
- GitHub Check: Deploy Preview and Test (videos-admin, 5120/merge, pull_request, 20)
- GitHub Check: Deploy Preview and Test (short-links, 5120/merge, pull_request, 20)
- GitHub Check: Deploy Preview and Test (journeys-admin, 5120/merge, pull_request, 20)
- GitHub Check: Deploy Preview and Test (journeys, 5120/merge, pull_request, 20)
- GitHub Check: Deploy Preview and Test (docs, 5120/merge, pull_request, 20)
- GitHub Check: Deploy Preview and Test (arclight, 5120/merge, pull_request, 20)
- GitHub Check: test (20, 3/3)
- GitHub Check: test (20, 2/3)
- GitHub Check: test (20, 1/3)
- GitHub Check: build (20)
🔇 Additional comments (52)
api/analytics/eslint.config.js (2)
7-8: LGTM! Verify path accuracy.The updated ignore paths align with the new directory structure, moving from
apps/api-analytics/toapi/analytics/.Let's verify that these files exist at the new locations:
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Verify that the ignored files exist at the new locations fd -t f "webpack.config.js|eslint.config.js" api/analytics/Length of output: 124
LGTM! Verified that the updated file paths are correct.
- Confirmed that both
api/analytics/eslint.config.jsandapi/analytics/webpack.config.jsexist in the new locations.
15-15: LGTM! Verify TypeScript config files.The updated TypeScript project path aligns with the new directory structure.
Let's verify that the TypeScript config files exist at the new location:
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Verify that the TypeScript config files exist at the new location fd -t f "tsconfig" api/analytics/Length of output: 126
LGTM! Verified the TypeScript config files.
The glob pattern matches the three config files found in theapi/analytics/directory:
tsconfig.app.jsontsconfig.jsontsconfig.spec.jsonThese results confirm that the updated path correctly aligns with the new directory structure.
api/journeys/eslint.config.js (2)
16-16: LGTM! Verify the updated paths.The path changes align with the PR objective of moving APIs to an 'api' folder.
Let's verify that the files exist at the new locations:
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Verify that the ESLint and webpack config files exist at the new locations # Test: Check if the files exist at the new paths fd -t f -e js "eslint.config.js|webpack.config.js" api/journeys/Length of output: 127
LGTM! Verified that the referenced configuration files exist at the new locations.
The shell script output confirms that both
api/journeys/eslint.config.jsandapi/journeys/webpack.config.jsare present under the new directory structure.
39-39: LGTM! Verify the TypeScript config files.The TypeScript config path update aligns with the PR objective.
Let's verify that the TypeScript config files exist at the new location:
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Verify that the TypeScript config files exist at the new location # Test: Check if any tsconfig files exist at the new path fd -t f -g "tsconfig*.json" api/journeys/Length of output: 133
TypeScript config files verified.
The new path
api/journeys/tsconfig.*?.jsonis correct, and the following config files were found:
api/journeys/tsconfig.app.jsonapi/journeys/tsconfig.jsonapi/journeys/tsconfig.spec.jsonapi/journeys-modern/src/schema/generate.ts (1)
10-10: Verify the schema file path accessibility.The path change aligns with the PR objective of moving API files to the "api" folder. However, we should verify that the new path exists and is accessible for read/write operations.
Run the following script to verify the path:
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Verify that the schema file path exists and is accessible. # Check if the directory exists if [ -d "api/journeys-modern" ]; then echo "Directory exists" else echo "Directory does not exist" fi # Check if the schema file exists and is readable/writable if [ -f "api/journeys-modern/schema.graphql" ]; then if [ -r "api/journeys-modern/schema.graphql" ] && [ -w "api/journeys-modern/schema.graphql" ]; then echo "Schema file exists and is readable/writable" else echo "Schema file exists but has incorrect permissions" fi else echo "Schema file does not exist" fiLength of output: 316
Schema file path is accessible and verified.
The output confirms that the directory and the schema file exist and have the correct permissions for read/write operations, ensuring the updated path meets the PR objectives.
api/journeys/codegen.ts (1)
4-7: LGTM! Path updates align with the new directory structure.The changes correctly update the paths from 'apps/' to 'api/' prefix, maintaining consistency with the project restructuring.
api/analytics/codegen.ts (1)
4-7: LGTM! Path updates align with the new directory structure.The changes correctly update the paths from 'apps/' to 'api/' prefix, maintaining consistency with the project restructuring.
api/analytics/jest.config.ts (1)
18-18: LGTM! Coverage directory path updated correctly.The coverage directory path has been updated to reflect the new directory structure.
.storybook/main.ts (1)
21-23: LGTM! Story paths updated correctly.The paths for 'api-journeys-modern' and 'api-users' stories have been updated to reflect the new directory structure.
api/journeys/src/app/app.module.ts (1)
76-76: LGTM! Path update aligns with project restructuring.The path change from 'apps/api-journeys/src/app//*.graphql' to 'api/journeys/src/app//*.graphql' correctly reflects the new directory structure.
Let's verify that the GraphQL schema files exist at the new location:
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Verify GraphQL schema files exist at the new location fd -e graphql . api/journeys/src/app/Length of output: 2876
GraphQL schema files verified at new location.
The shell script confirms that numerous *.graphql files exist in the
api/journeys/src/app/directory, affirming that the path update correctly aligns with the project's restructuring.api/gateway/Dockerfile (1)
10-11: LGTM! Path updates align with project restructuring.The COPY commands have been correctly updated to reflect the new directory structure, moving from 'apps/api-gateway' to 'api/gateway'.
Let's verify the existence of the copied files:
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Verify the existence of gateway files at new location test -f api/gateway/gateway.prod.config.ts && echo "Config file exists" || echo "Config file missing" test -d api/gateway/src && echo "Source directory exists" || echo "Source directory missing"Length of output: 174
Verified: All updated paths are correct.
api/gateway/gateway.prod.config.tsexists.api/gateway/srcdirectory exists.api/journeys/Dockerfile (2)
14-14: Updated Distribution Files Path in COPY Command
The COPY command on line 14 now uses./dist/api/journeyswhich correctly reflects the new directory structure after the reorganization.
21-21: Updated Database Files Path in COPY Command
The COPY command on line 21 has been updated from the old path to./api/journeys/db, ensuring consistency with the new project layout. Please verify that the target folder exists and contains all required database artifacts.api/gateway/project.json (5)
4-4: UpdatedsourceRootSetting
ThesourceRootis now set to"api/gateway/src", which aligns with the new folder structure. Ensure that all related import paths and tooling configurations have been updated accordingly.
11-11: Updated Gateway Config Command Path
The command in theservetarget (line 11) now correctly references./api/gateway/gateway.config.ts. This change is consistent with the new project layout.
30-30: Updated GraphQL Generation Command Paths
Thegenerate-graphqltarget on line 30 now uses new schema paths (e.g../api/analytics/schema.graphql,./api/journeys/schema.graphql, etc.). Confirm that each referenced schema file exists in its new location and that the overall command syntax fits your deployment requirements.
36-36: Updated Secrets Fetch Command Path
The fetch-secrets command on line 36 has been updated to output the environment file toapi/gateway/.env. This is consistent with the reorganization, but please verify that downstream processes reference the new file path.
42-42: Updated TypeScript Configuration Path
Thetype-checktarget’s command now points toapi/gateway/tsconfig.json(line 42), which correctly reflects the new structure..github/workflows/api-gateway-prod-worker.yml (2)
46-46: Updated Affected Apps Pattern
The command on line 46 now uses the patternapi/*instead ofapps/api-*. This broader matching is appropriate after the reorganization.
71-71: Updated Dockerfile Reference in Build Command
The Docker build command on line 71 now correctly uses-f api/gateway/Dockerfileto refer to the Dockerfile in its new location. Ensure that the Docker build context and subsequent deployment steps are consistent with this path update..github/workflows/api-gateway-stage-worker.yml (2)
46-46: Updated Affected Apps Pattern in Stage Workflow
Similar to the production workflow, line 46 now uses the patternapi/*to detect affected applications. This update correctly aligns with the reorganized directories.
71-71: Updated Dockerfile Reference in Stage Build Command
The Docker build command on line 71 now correctly points to-f api/gateway/Dockerfile, matching the new file location. Please verify that this path is correct in all stage deployment contexts.api/analytics/project.json (8)
4-4: UpdatedsourceRootConfiguration
ThesourceRoothas been updated to"api/analytics/src"on line 4. This change is in line with the project reorganization.
13-18: Updated Build Options for New Directory Structure
Lines 13–18 now specify updated paths:
"outputPath": "dist/api/analytics""main": "api/analytics/src/index.ts""tsConfig": "api/analytics/tsconfig.app.json""webpackConfig": "api/analytics/webpack.config.js"
These updates ensure that the build process targets the correct new locations. Please verify that all referenced files exist and build as expected.
51-57: Revised Test Configuration
The test target now outputs coverage to"{workspaceRoot}/coverage/api/analytics"and uses"api/analytics/jest.config.ts"for configuration (lines 51–57). This update correctly reflects the new structure for test artifacts.
58-62: Updated GraphQL Generation Command in Analytics
The command on line 61 for thegenerate-graphqltarget now uses the new TypeScript configuration and source path (api/analytics/src/schema/index.ts). Confirm that the GraphQL schema generation works as expected with these updated paths.
64-69: Updated Subgraph Check Command
The subgraph-check target (lines 64–69) now referencesapi/analytics/schema.graphql. This is consistent with the reorganization; please ensure that the schema file is available at the specified location.
70-75: Updated Secrets Fetch Command in Analytics
The command on line 73 outputs the secrets file toapi/analytics/.env, which reflects the new project layout. Double-check that all systems looking for secrets use this updated path.
76-98: Prisma Commands Alignment with New Paths
The various Prisma commands (in targetsprisma-generate,prisma-studio,prisma-validate, andprisma-introspect) now use the schema file atapi/analytics/db/schema.prisma(lines 76–98). These updates appear consistent; please verify that Prisma generates and validates your schema without issues.
114-119: Updated Codegen Command in Analytics
The codegen target (lines 114–119) now refers toapi/analytics/tsconfig.jsonin its command. This change is consistent with the reorganization; please ensure that the code generation tool locates the correct TypeScript configuration file..github/workflows/api-deploy-worker.yml (1)
69-73: Update Affected Apps Command to Reflect New Directory StructureThe command now uses the pattern
api/*instead of the oldapps/api-*, which aligns with the reorganization of API-related files. This change should ensure that all projects within the new "api" folder are correctly detected and deployed.api/journeys/project.json (21)
4-4: Update Project Source RootThe
"sourceRoot"has been updated from the previous location (likely"apps/api-journeys/src") to"api/journeys/src". This correctly reflects the new file structure for the API journeys project.
12-14: Update Build Options: Output, Main, and TypeScript ConfigurationThe build options—specifically
"outputPath","main", and"tsConfig"—are now updated to point to the new locations underapi/journeys. This ensures that the build artifacts and compilation settings are correctly aligned with the reorganized folder layout.
15-19: Update Assets ConfigurationThe assets configuration now uses the path
"api/journeys/src/assets"and updates the"input"for GraphQL files to"api/journeys/src/app/". This change guarantees that static assets and GraphQL files are correctly sourced from the new directory structure.
30-30: Update Webpack Configuration PathThe
"webpackConfig"option is updated to"api/journeys/webpack.config.js", which ensures the webpack build process references the correct configuration file in the new location.
40-41: Update Environment File Replacement PathsThe file replacement configuration for the production environment now correctly replaces
"api/journeys/src/environments/environment.ts"with"api/journeys/src/environments/environment.prod.ts". This reflects the new project structure.
57-57: Update Typings Generation Command in Watcher TargetThe watcher’s command now runs
"npm run ts-node tools/scripts/generate-typings.ts journeys --transpileOnly". This change seems intended to align the typings generation with the new naming convention for the journeys project.
70-78: Update Jest/Test ConfigurationThe test target has been modified to:
- Output coverage reports to
"{workspaceRoot}/coverage/api/journeys".- Use the Jest config file at
"api/journeys/jest.config.ts".- Replace the environment file for testing using paths within
"api/journeys/src/environments/".These updates ensure that the testing configuration now reflects the new API journeys structure.
85-86: Update GraphQL Code Generation CommandThe code generation command now points to the new config file
"api/journeys/codegen.ts", which is consistent with the reorganization.
91-92: Update Generate-GraphQL CommandThe
"generate-graphql"target now uses the new schema output path (api/journeys/schema.graphql), ensuring that introspection results are stored correctly.
97-98: Update Subgraph-Check CommandThe subgraph check command now calls
npx hive schema:check api/journeys/schema.graphql …to validate the schema in its new location. This change is consistent with other path updates.
103-104: Update Secrets Fetch CommandThe command for fetching secrets now downloads them into
api/journeys/.env, ensuring that environment secrets are stored alongside the project’s new structure.
111-112: Update Prisma-Generate CommandsBoth Prisma commands in the
"prisma-generate"target now reference the schema atapi/journeys/db/schema.prismaand invoke the casl generator from the updated source path. This ensures that Prisma tooling works with the project's new layout.
120-121: Update Prisma-Migrate (Dev) CommandThe development migration command now uses the schema from
api/journeys/db/schema.prisma. This update is necessary for keeping migration operations in line with the new folder structure.
125-126: Update Prisma-Migrate (Deploy) CommandThe deploy migration command is updated to use the new schema path, ensuring consistency during production deployment migrations.
135-136: Update Prisma Reset CommandThe reset command for Prisma now references the schema in
api/journeys/db/schema.prismaand forces the reset. This change is aligned with the restructured project directories.
142-143: Update Prisma Seed CommandThe seed command now runs from
api/journeys/db/seed.ts, keeping all Prisma-related scripts within the new API journeys folder.
148-149: Update Prisma Studio CommandThe
"prisma-studio"target now correctly points to the schema atapi/journeys/db/schema.prisma, ensuring that the Prisma Studio tool loads the correct schema.
155-156: Update Prisma Validate CommandThe validate command now references the updated Prisma schema path (
api/journeys/db/schema.prisma), which is consistent with the migration of the database schema files.
163-164: Update Prisma Resolve CommandThe resolve command now uses the schema in its new location and includes the migration identifier. Verify that the hard-coded migration ID (
20230711193802_20230711193801) is still correct in the new context.
170-171: Update Type-Check CommandThe command for type-checking now points to
api/journeys/tsconfig.json, ensuring that the TypeScript build respects the new project layout.
176-177: Review Codecov Coverage Flag ConsistencyThe Codecov command now uses the coverage file located at
coverage/api/journeys/cobertura-coverage.xml; however, the flag-F apps.api-journeysstill references the old folder naming. Please verify whether this flag should be updated to reflect the new structure (e.g.,-F api.journeysor similar).
| ignores: [ | ||
| 'apps/api-users/eslint.config.js', | ||
| 'apps/api-users/webpack.config.js' | ||
| 'api/journeys-modern/eslint.config.js', | ||
| 'api/journeys-modern/webpack.config.js' | ||
| ] |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify the existence of referenced configuration files.
The path changes align with the PR objective. Let's verify that all referenced configuration files exist in their new locations.
Run the following script to verify the paths:
Also applies to: 31-31
🏁 Script executed:
#!/bin/bash
# Description: Verify that all referenced configuration files exist.
# Check ESLint config
if [ -f "api/journeys-modern/eslint.config.js" ]; then
echo "ESLint config exists"
else
echo "ESLint config does not exist"
fi
# Check Webpack config
if [ -f "api/journeys-modern/webpack.config.js" ]; then
echo "Webpack config exists"
else
echo "Webpack config does not exist"
fi
# Check TypeScript configs
echo "TypeScript configs:"
fd -e json -g "api/journeys-modern/tsconfig*.json"Length of output: 306
Action Required: Missing TypeScript configuration file reference.
- The ESLint configuration file (
api/journeys-modern/eslint.config.js) exists. - The Webpack configuration file (
api/journeys-modern/webpack.config.js) exists. - No TypeScript configuration files (e.g.
tsconfig*.json) were found in theapi/journeys-moderndirectory, even though the parserOptions were updated to reference them.
Please verify that the TypeScript configuration file has been correctly moved to the expected location or update the parserOptions reference accordingly.
api/analytics/Dockerfile
Outdated
|
|
||
| WORKDIR /app | ||
| COPY ./dist/apps/api-analytics . | ||
| COPY ./dist/api/analytics . |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
LGTM! Path updates align with project restructuring.
The COPY commands have been correctly updated to reflect the new directory structure:
- Distribution files path updated from 'dist/apps/api-analytics' to 'dist/api/analytics'
- Database files path updated from 'apps/api-analytics/db' to 'api/analytics/db'
Let's verify the existence of the copied files:
Also applies to: 21-21
🏁 Script executed:
#!/bin/bash
# Verify the existence of analytics files at new location
test -d dist/api/analytics && echo "Dist directory exists" || echo "Dist directory missing"
test -d api/analytics/db && echo "DB directory exists" || echo "DB directory missing"Length of output: 159
Critical Issue: Missing Distribution Directory
The database directory (api/analytics/db) exists as expected, but the distribution directory (dist/api/analytics) is missing. This discrepancy indicates that although the Dockerfile update correctly reflects the new path for database files, the updated path for the distribution files currently does not exist in your project structure. Please verify your build process or output directory configuration for the analytics distribution files.
api/journeys-modern/Dockerfile
Outdated
|
|
||
| WORKDIR /app | ||
| COPY ./dist/apps/api-journeys-modern . | ||
| COPY ./dist/api/journeys-modern . |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
LGTM! Path updates align with project restructuring.
The COPY commands have been correctly updated to reflect the new directory structure:
- Distribution files path updated from 'dist/apps/api-journeys-modern' to 'dist/api/journeys-modern'
- Database files path updated from 'apps/api-journeys-modern/db' to 'api/journeys-modern/db'
Let's verify the existence of the copied files:
Also applies to: 21-21
🏁 Script executed:
#!/bin/bash
# Verify the existence of journeys-modern files at new location
test -d dist/api/journeys-modern && echo "Dist directory exists" || echo "Dist directory missing"
test -d api/journeys-modern/db && echo "DB directory exists" || echo "DB directory missing"Length of output: 171
Critical: Distribution directory missing in expected path
- The
COPY ./dist/api/journeys-modern .command in the Dockerfile is expected to copy files from thedist/api/journeys-moderndirectory, but the verification script showed that this directory is missing. - The database directory (
api/journeys-modern/db) exists as expected. - Please ensure that the build process correctly outputs the distribution files to
dist/api/journeys-modernor update the Dockerfile's path if the output location has changed.
mikeallisonJS
changed the title
coderabbitai
bot
added
effort: 1
priority: now
type: chore
github-actions
bot
had a problem deploying
to
Preview - journeys-admin
|
Ran Plan for dir: Show OutputTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.datadog.module.datadog_log_forwarder.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "datadog-log-forwarder"
tags = {
"DD_FORWARDER_VERSION" = "3.73.0"
}
# (30 unchanged attributes hidden)
~ environment {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ variables = (sensitive value)
}
# (2 unchanged blocks hidden)
}
# module.datadog.module.datadog_rds_enhanced_monitoring_forwarder.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "datadog-rds-enhanced-monitoring-forwarder"
tags = {
"DD_FORWARDER_VERSION" = "3.73.0"
}
# (28 unchanged attributes hidden)
~ environment {
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ variables = (sensitive value)
}
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
Plan: 0 to add, 2 to change, 0 to destroy.
|
github-actions
bot
requested a deployment
to
Preview - journeys-admin
|
Merge conflict attempting to merge this into stage. Please fix manually. |
|
Merge conflict attempting to merge this into stage. Please fix manually. |
|
Ran Plan for dir: No changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.
|
|
Ran Plan for dir: No changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.
|
mikeallisonJS
deleted the
mikeallison/eng-1845-move-apis-to-api-folder-no-qa
branch
|
Locks and plans deleted for the projects and workspaces modified in this pull request:
|
Summary by CodeRabbit