Skip to content

feat: add language type to response#6740

Merged
mikeallisonJS merged 5 commits into
feature/25-04-MA-feat-ai-translationfrom
mikeallison/nes-23-add-language-type-to-response
May 22, 2025
Merged

feat: add language type to response#6740
mikeallisonJS merged 5 commits into
feature/25-04-MA-feat-ai-translationfrom
mikeallison/nes-23-add-language-type-to-response

Conversation

@mikeallisonJS
Copy link
Copy Markdown
Collaborator

No description provided.

tanflem and others added 2 commits May 22, 2025 20:53
- Modified the `language` field in the Journey type to include `@shareable` directive in api-journeys and api-journeys/src/app/modules/journey.
- Enhanced the Language type in api-journeys-modern to support federation with the addition of `@key` and `@extends` directives.
- Updated schema imports in api-journeys-modern to include the new Language type.

These changes improve schema consistency and support for language-related features across the application.
@mikeallisonJS mikeallisonJS requested a review from edmonday May 22, 2025 21:18
@mikeallisonJS mikeallisonJS self-assigned this May 22, 2025
@linear
Copy link
Copy Markdown

linear Bot commented May 22, 2025

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot temporarily deployed to Preview - arclight May 22, 2025 21:20 Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2025

The latest updates on your projects.

Name Status Preview Updated (UTC)
arclight ✅ Ready arclight preview Fri May 23 09:41:45 NZST 2025

@github-actions github-actions Bot temporarily deployed to Preview - videos-admin May 22, 2025 21:24 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - arclight May 22, 2025 21:24 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - short-links May 22, 2025 21:24 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - journeys May 22, 2025 21:24 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - watch May 22, 2025 21:24 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - journeys-admin May 22, 2025 21:24 Inactive
@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
short-links ✅ Ready short-links preview Fri May 23 09:26:08 NZST 2025

@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch ✅ Ready watch preview Fri May 23 09:26:37 NZST 2025

@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys ✅ Ready journeys preview Fri May 23 09:26:49 NZST 2025

@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
videos-admin ✅ Ready videos-admin preview Fri May 23 09:27:02 NZST 2025

@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready journeys-admin preview Fri May 23 09:27:22 NZST 2025

- Updated the `language` field in the Journey type across multiple schemas to be non-nullable, ensuring that a language is always specified.
- This change enhances data integrity and consistency in the application by preventing potential null values for language fields in journey-related queries and mutations.
@github-actions github-actions Bot temporarily deployed to Preview - arclight May 22, 2025 21:39 Inactive
@mikeallisonJS mikeallisonJS merged commit ecd47ae into feature/25-04-MA-feat-ai-translation May 22, 2025
18 checks passed
@mikeallisonJS mikeallisonJS deleted the mikeallison/nes-23-add-language-type-to-response branch May 22, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants