Skip to content

Conversation

@csiyang
Copy link
Contributor

@csiyang csiyang commented Jul 30, 2025

Summary by CodeRabbit

  • New Features

    • Introduced grid and list display variants for radio question options, allowing options to be shown as cards with images or as a vertical list.
    • Added support for displaying placeholder grayscale logo images when no option image is provided.
    • Enhanced the "Add Option" button for both grid and list views with improved styling and accessibility.
  • Bug Fixes

    • Improved test coverage and updated test selectors to align with new UI structures and identifiers.
  • Style

    • Updated styling for radio options to better support both grid and list layouts, including theme-aware colors, spacing, and interactive states.
  • Documentation

    • Updated localization strings for "Add Option" and removed unused or redundant translations.
  • Tests

    • Added and updated tests for grid and list variants, verifying rendering, interaction, and add option functionality.
  • Chores

    • Refactored component structure to separate grid and list variants and streamline option rendering.
    • Simplified option addition by delegating "Add Option" UI handling to radio question variants.
    • Added a grayscale logo placeholder image for options without images.

Kneesal and others added 30 commits July 28, 2025 02:34
…-enhancement' of https://github.com/JesusFilm/core into nisalcottingham/nes-532-implement-poll-block-properties-enhancement
…-enhancement' into siyangcao/nes-579-poll-block-image-display
…-enhancement' of https://github.com/JesusFilm/core into nisalcottingham/nes-532-implement-poll-block-properties-enhancement
@csiyang csiyang added this pull request to the merge queue Aug 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 4, 2025
@csiyang csiyang added this pull request to the merge queue Aug 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 4, 2025
@github-actions github-actions bot temporarily deployed to Preview - watch-modern August 4, 2025 04:01 Inactive
@github-actions github-actions bot temporarily deployed to Preview - arclight August 4, 2025 04:01 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys August 4, 2025 04:01 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin August 4, 2025 04:01 Inactive
@github-actions github-actions bot temporarily deployed to Preview - videos-admin August 4, 2025 04:01 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys August 4, 2025 04:19 Inactive
@github-actions github-actions bot temporarily deployed to Preview - watch August 4, 2025 04:19 Inactive
@github-actions github-actions bot temporarily deployed to Preview - watch-modern August 4, 2025 04:19 Inactive
@github-actions github-actions bot temporarily deployed to Preview - arclight August 4, 2025 04:19 Inactive
@github-actions github-actions bot temporarily deployed to Preview - videos-admin August 4, 2025 04:19 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin August 4, 2025 04:19 Inactive
@csiyang csiyang added this pull request to the merge queue Aug 4, 2025
Merged via the queue into main with commit 1de643f Aug 4, 2025
33 of 34 checks passed
@csiyang csiyang deleted the siyangcao/nes-579-poll-block-image-display branch August 4, 2025 20:44
@jesus-film-bot
Copy link

Locks and plans deleted for the projects and workspaces modified in this pull request:

  • dir: infrastructure workspace: default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants