Skip to content

feat: add image editing section#8710

Merged
jaco-brink merged 22 commits intofeature/26-01-JB-story-1from
jacobusbrink/nes-1284-image-editing-section
Feb 12, 2026
Merged

feat: add image editing section#8710
jaco-brink merged 22 commits intofeature/26-01-JB-story-1from
jacobusbrink/nes-1284-image-editing-section

Conversation

@jaco-brink
Copy link
Copy Markdown
Collaborator

No description provided.

jianwei1 and others added 8 commits February 5, 2026 03:31
Added new components for BackgroundImageSection, BackgroundVideoSection, CardsSection, ImagesSection, LogoSection, and VideosSection, along with their respective tests. Each section is designed to render with a data-testid for testing purposes.
Added an index file to streamline the export of media sections including LogoSection, CardsSection, ImagesSection, VideosSection, BackgroundImageSection, and BackgroundVideoSection for easier imports in the customization flow.
Introduced utility functions for managing the visibility of media sections including Logo, Images, Videos, Background Image, and Background Video. Each section has corresponding tests to ensure functionality. This enhances the customization flow for media components.
Updated the MediaScreen component to conditionally render media sections (Logo, Images, Videos, Background Image, and Background Video) based on utility functions. Added a test to verify the presence of these sections when the screen is displayed, improving the customization flow for media components.
@linear
Copy link
Copy Markdown

linear Bot commented Feb 10, 2026

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jacobusbrink/nes-1284-image-editing-section

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 10, 2026

Warnings
⚠️ ❗ Big PR (1323 changes)

(change count - 1323): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against 9d401ea

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Feb 10, 2026

View your CI Pipeline Execution ↗ for commit 9d401ea

Command Status Duration Result
nx run watch-e2e:e2e ✅ Succeeded 23s View ↗
nx run journeys-admin-e2e:e2e ✅ Succeeded 32s View ↗
nx run journeys-e2e:e2e ✅ Succeeded 22s View ↗
nx run resources-e2e:e2e ✅ Succeeded 12s View ↗
nx run videos-admin-e2e:e2e ✅ Succeeded 6s View ↗
nx run player-e2e:e2e ✅ Succeeded 3s View ↗
nx run watch-modern-e2e:e2e ✅ Succeeded 5s View ↗
nx run-many --target=vercel-alias --projects=jo... ✅ Succeeded 2s View ↗
Additional runs (20) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2026-02-11 20:42:30 UTC

@github-actions github-actions Bot requested a deployment to Preview - journeys-admin February 10, 2026 03:36 Pending
@github-actions github-actions Bot temporarily deployed to Preview - journeys-admin February 10, 2026 03:40 Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 10, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready journeys-admin preview Thu Feb 12 09:37:26 NZDT 2026

@github-actions github-actions Bot temporarily deployed to Preview - journeys-admin February 11, 2026 01:24 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - journeys-admin February 11, 2026 01:46 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - journeys-admin February 11, 2026 02:39 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - journeys-admin February 11, 2026 03:37 Inactive
@jaco-brink jaco-brink requested a review from edmonday February 11, 2026 19:39
@jaco-brink jaco-brink self-assigned this Feb 11, 2026
@github-actions github-actions Bot temporarily deployed to Preview - journeys-admin February 11, 2026 19:41 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - journeys-admin February 11, 2026 19:59 Inactive
@github-actions github-actions Bot had a problem deploying to Preview - journeys-admin February 11, 2026 20:19 Failure
@jaco-brink jaco-brink marked this pull request as ready for review February 11, 2026 20:21
@github-actions github-actions Bot requested a deployment to Preview - journeys-admin February 11, 2026 20:29 Pending
@github-actions github-actions Bot temporarily deployed to Preview - journeys February 11, 2026 20:32 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - journeys-admin February 11, 2026 20:32 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - resources February 11, 2026 20:32 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - videos-admin February 11, 2026 20:32 Inactive
@github-actions github-actions Bot temporarily deployed to Preview - watch-modern February 11, 2026 20:32 Inactive
@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
player ✅ Ready player preview Thu Feb 12 09:34:47 NZDT 2026

@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch-modern ✅ Ready watch-modern preview Thu Feb 12 09:34:56 NZDT 2026

@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys ✅ Ready journeys preview Thu Feb 12 09:35:29 NZDT 2026

@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
videos-admin ✅ Ready videos-admin preview Thu Feb 12 09:35:32 NZDT 2026

@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch ✅ Ready watch preview Thu Feb 12 09:36:09 NZDT 2026

@github-actions
Copy link
Copy Markdown
Contributor

The latest updates on your projects.

Name Status Preview Updated (UTC)
resources ✅ Ready resources preview Thu Feb 12 09:36:10 NZDT 2026

@jaco-brink jaco-brink merged commit a581f8d into feature/26-01-JB-story-1 Feb 12, 2026
29 of 31 checks passed
@jaco-brink jaco-brink deleted the jacobusbrink/nes-1284-image-editing-section branch February 12, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants