feat: update iconBlockCreate mutation to use modern API and import ne…#8883
Merged
mikeallisonJS merged 22 commits intomainfrom Mar 25, 2026
Merged
feat: update iconBlockCreate mutation to use modern API and import ne…#8883mikeallisonJS merged 22 commits intomainfrom
mikeallisonJS merged 22 commits intomainfrom
Conversation
- Moved `buttonBlockUpdate` mutation to the modern API schema and adjusted its input type. - Updated `cardBlockCreate` mutation to use the modern API. - Removed deprecated `journeyId` parameter from `buttonBlockUpdate` in the legacy schema. - Cleaned up related resolver and input files for consistency and clarity.
…for modern API - Removed the `cardBlockCreate` mutation from the legacy API and adjusted related resolver tests. - Updated the `cardBlockUpdate` mutation to include the `journeyId` parameter in the modern API schema. - Cleaned up input types and resolver files for consistency across APIs.
- Eliminated the `CardBlockCreateInput` type from the resolver and related test files. - Streamlined the `card.resolver.ts` and `card.resolver.spec.ts` for improved clarity and consistency.
- Changed the `cardBlockUpdate` mutation in both legacy and modern API schemas to make the return type non-nullable. - Updated the `journeyId` parameter in the `cardBlockUpdate` mutation to be non-nullable in the modern API schema. - Ensured consistency across API schemas by aligning mutation definitions.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe pull request updates the GraphQL federation routing of the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 9d6baee
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 8435fed
☁️ Nx Cloud last updated this comment at |
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
I see you added the "on stage" label, I'll get this merged to the stage branch! |
csiyang
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…w mutation file
Summary by CodeRabbit