Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughThis PR extends the GraphQL schema to share the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit b625486
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit b625486 ☁️ Nx Cloud last updated this comment at |
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
The regex in renderEditableText required at least one character after the
colon (`[^}]+`), so tokens like `{{key: }}` generated by
formatTemplateCustomizationString never matched and rendered as plain text.
Updated the regex to make the colon+value group optional and allow empty
values (`[^}]*`). Also adds error handling with snackbar feedback when the
mutation fails.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ption fix Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
csiyang
force-pushed
the
siyangcao/nes-1444-error-customizing-fill-in-words-in-ad-templates
branch
from
2472434 to
b625486
Compare
mikeallisonJS
approved these changes
Apr 1, 2026
Contributor
|
I see you added the "on stage" label, I'll get this merged to the stage branch! |
Contributor
|
Merge conflict attempting to merge this into stage. Please fix manually. |
csiyang
deleted the
siyangcao/nes-1444-error-customizing-fill-in-words-in-ad-templates
branch
tanflem
pushed a commit
that referenced
this pull request
Apr 3, 2026
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex in renderEditableText required at least one character after the
colon (
[^}]+), so tokens like{{key: }}generated byformatTemplateCustomizationString never matched and rendered as plain text.
Updated the regex to make the colon+value group optional and allow empty
values (
[^}]*). Also adds error handling with snackbar feedback when themutation fails.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Summary by CodeRabbit