refactor: remove child translation templates#9151
Conversation
Deleted the generated files for GetChildJourneysFromTemplateId and GetParentJourneysFromTemplateId, along with their associated hooks and mocks. Updated JourneyCardMenuItem, CopyToTeamMenuItem, LanguageScreen, and CopyToTeamDialog components to remove references to the deleted queries. This cleanup improves code maintainability and reduces unnecessary dependencies.
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR adds ESLint disable directives to i18next config files, extends TypeScript image module declarations across multiple apps, removes template-hierarchy language-fetching hooks, simplifies the LanguageScreen to rely on direct journey language comparison instead of template mappings, and removes ChangesConfiguration & Type Declarations
Template Language Query Removal & Dialog Simplification
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 9ae8c65
☁️ Nx Cloud last updated this comment at |
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
…move-child-translation-templates
|
I see you added the "on stage" label, I'll get this merged to the stage branch! |
|
Merge conflict attempting to merge this into stage. Please fix manually. |
…ateId on CopyToTeamDialog PR #9151 (refactor: remove child translation templates, 2026-05-14) landed on main after this branch was cut and removed `journeyIsTemplate` + `journeyFromTemplateId` from `CopyToTeamDialog` (along with the publisher-side "disable copy-and-translate for non-original templates" guard that consumed them). `UseTemplateDeepLink` was authored against the pre-removal interface and still passed those props, so the PR merge preview (pull/9173/merge) fails journeys-admin type-check even though the branch tip alone is clean. CI failure was reproducible across two lint-work runs but not locally — local doesn't have main merged in. Dropping the two props from the JSX is the correct resolution: the "disable for non-original templates" logic was the only consumer and it's gone. The deep-link receiver is consumed by anyone with the URL, not just publishers, so the publisher-specific gate didn't apply here anyway. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Siyang Cao <67619008+csiyang@users.noreply.github.com>
Deleted the generated files for GetChildJourneysFromTemplateId and GetParentJourneysFromTemplateId, along with their associated hooks and mocks. Updated JourneyCardMenuItem, CopyToTeamMenuItem, LanguageScreen, and CopyToTeamDialog components to remove references to the deleted queries. This cleanup improves code maintainability and reduces unnecessary dependencies.
Summary by CodeRabbit
Release Notes
Refactor
Chores