Skip to content

feat(cms): allow Container in Section content dynamic zone#202

Merged
Ur-imazing merged 1 commit intomainfrom
fix/section-content-add-container
Mar 5, 2026
Merged

feat(cms): allow Container in Section content dynamic zone#202
Ur-imazing merged 1 commit intomainfrom
fix/section-content-add-container

Conversation

@Ur-imazing
Copy link
Copy Markdown
Contributor

@Ur-imazing Ur-imazing commented Mar 5, 2026

Resolves #145

Related epic: #175

Summary

Allow Section content dynamic zone to include the Container component so editors can add side-by-side blocks inside a Section. Schema (section.json, schema.graphql) and generated client (graphql-env.d.ts) updated. No new component types; only extends Section content union.

Contracts Changed

  • yes
  • no

Regeneration Required

  • yes
  • no

Validation

  • Contracts validated
  • Generated code verified (no manual edits)
  • Tests and build passed
  • Terraform plan reviewed (if infra change)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c4baf9e2-2b93-4f29-b16d-c85a4d12b912

📥 Commits

Reviewing files that changed from the base of the PR and between 64ca334 and ad25664.

📒 Files selected for processing (3)
  • apps/cms/schema.graphql
  • apps/cms/src/components/sections/section.json
  • packages/graphql/src/graphql-env.d.ts

Walkthrough

The pull request extends the SectionContentDynamicZone union to include a new ComponentSectionsContainer type across the GraphQL schema, component configuration, and TypeScript type definitions, enabling editors to use a Container component within Section content blocks.

Changes

Cohort / File(s) Summary
CMS Schema and Component Configuration
apps/cms/schema.graphql, apps/cms/src/components/sections/section.json
Added ComponentSectionsContainer to the SectionContentDynamicZone union and registered "sections.container" component in the dynamiczone "content" components list.
TypeScript Type Definitions
packages/graphql/src/graphql-env.d.ts
Updated SectionContentDynamicZone possibleTypes to include 'ComponentSectionsContainer' as a valid concrete type.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR adds Container to the Section content dynamic zone, partially addressing issue #145 requirements. However, the linked issue specifically requires a Section component with background color, blur hash, and repeatable children attributes, which are not evident in this changeset. Verify that the Section component schema includes all required attributes (backgroundColor, blurHash) and accepts Container as a repeatable child component per issue #145 acceptance criteria.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: adding the Container component as an allowed type in the Section content dynamic zone.
Out of Scope Changes check ✅ Passed All changes are in-scope: GraphQL schema, CMS component configuration, and generated TypeScript types are all directly related to enabling Container in the Section dynamic zone.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/section-content-add-container

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Ur-imazing Ur-imazing merged commit 3b7824e into main Mar 5, 2026
18 of 19 checks passed
@Ur-imazing Ur-imazing deleted the fix/section-content-add-container branch March 5, 2026 00:41
Kneesal pushed a commit to Kneesal/forge that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(cms): add schema for Section component (background, blur hash, children)

1 participant