chore(mobile-expo): CI lint, typecheck, and build for Expo app#318
chore(mobile-expo): CI lint, typecheck, and build for Expo app#318Ur-imazing merged 5 commits intomainfrom
Conversation
Add @forge/expo to the affected-package detection in CI, exclude it from the monorepo-wide lint job, and add a dedicated lint-expo job that runs lint (--max-warnings=0), typecheck, and build when Expo code changes. Mirrors the existing lint-ios and lint-android pattern. Resolves #96 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds Expo detection to CI and a new conditional Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace the echo placeholder with `npx expo export --platform all` so CI validates the full Metro JS bundle for iOS and Android, catching broken imports and missing assets that typecheck alone cannot detect. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The build-and-test job runs `pnpm build` across all packages, which now triggers `expo export --platform all` for @forge/expo. This fails because web dependencies (react-dom, react-native-web) are not installed. Exclude @forge/expo (and other mobile/infra packages) from the monorepo-wide build, matching the lint exclusion pattern. The dedicated lint-expo job handles Expo builds independently. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Revert the expo export build swap and build-and-test exclusion. The package.json change is out of scope for this CI-only issue. The build step remains a no-op echo, so no exclusion is needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
@forge/expoto the Turborepo affected-package detection in CI@forge/expofrom the monorepo-wide lint job (like other mobile packages)lint-expoCI job that runs lint (--max-warnings=0), typecheck, and build for the Expo appResolves #96
Contracts Changed
None
Regeneration Required
No
Validation
lint-iosandlint-androidpatternsneeds.affected.outputs.mobile_expo == 'true'so it only runs when Expo code changesTest plan
mobile/expo/and verify thelint-expojob triggersmobile/expo/and verify thelint-expojob is skipped@forge/expo🤖 Generated with Claude Code
Summary by CodeRabbit