CSS auto keyword #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I02b655e02ee0004de9a628bc319db880e1c3ed3d
olonho
pushed a commit
that referenced
this pull request
Sep 27, 2021
This avoids the scenario where: 1. The user runs busytown/androidx.sh 2. Gradle builds aar files for group1 3. Gradle builds a .zip file of group1 4. Gradle builds aar files for group2 5. Gradle builds a .zip file of group2 6. busytown/androidx.sh runs Gradle again to confirm that all tasks are UP-TO-DATE 7. Gradle checks whether the .zip of group1 is UP-TO-DATE 8. Gradle finds that because more aar files have been created (#4) since the .zip of group1 was last built (#3), the task must be rerun 9. The build fails because when running the build twice in a row, a task was not UP-TO-DATE Bug: 200574943 Test: Treehugger runs busytown/androidx.sh Change-Id: I6c8c4e83dfb251e506d91412cb905a7ef372ab11
igordmn
pushed a commit
that referenced
this pull request
Jan 30, 2024
This CL adds a hoisted ScrollState to BasicTextField2 to enable horizontal and vertical scroll. Like the existing `BasicTextField`, BTF2 only supports single orientated scrolling. Single line configuration disables `softWrap` and enables horizontal scroll. Multi-line configuration does the exact opposite to enable vertical scroll. Cursor is kept in visible area only when it's shown (focused, editable). There is also a fix to clip test for `BasicTextField`. The previous test only looked at the area #4, but in fact it needs to check #2, #3, #4 for any spill from BasicTextField. // BasicTextField is #1 // Wrapping box is all the area visible below ----- |1|2| ----- |3|4| ----- Relnote: N/A Test: :compose:foundation:foundation:cAT Change-Id: Iccac198dec2d2908c4c51ddfaf40dcb05515ce70
MatkovIvan
pushed a commit
that referenced
this pull request
Sep 30, 2025
Deciding TalkBack whether it should intercept RSB movtion events to navigate a11y focus is based on the input focus. If the scrollable node fail to acquire input focus, TalkBack would treat it that RSB motion events could be used by the input focused node and then it doesn't intercept RSB movetion events. Therefore, if we want to navigate a11y focus by RSB, we need to request input focus to the scrollable node which has CollectionInfo. Node #1 at (l=0.0, t=0.0, r=119.0, b=456.0)px |-Node #2 at (l=0.0, t=0.0, r=119.0, b=456.0)px, Tag: 'scalingLazyColumn' |-Node #4 at (l=0.0, t=-22.0, r=119.0, b=478.0)px CollectionInfo = 'androidx.compose.ui.semantics.CollectionInfo@8d7827' Focused = 'true' ... Bug: b/445332360 Test: Run wear.compose.integration-tests.demos Change-Id: I6be3cd527a60eb95679889e4c86e8240530894b0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I02b655e02ee0004de9a628bc319db880e1c3ed3d
Proposed Changes
Testing
Test: Describe how you tested your changes. Note that this line (with
Test:) is required, your PR will not build without it!Issues Fixed
Fixes: [Optional] The bug on https://issuetracker.google.com being fixed