Fix e2e-tests#97
Merged
Merged
Conversation
Julien Arzul (JulienArzul)
requested review from
a team,
Ruslan Golov (RuslanGolov),
Lenar (catstrike) and
Sergey (hsestupin)
Julien Arzul (JulienArzul)
force-pushed
the
jarzul/fix-e2e-tests
branch
from
f9c4292 to
35a2e33
Compare
Julien Arzul (JulienArzul)
force-pushed
the
jarzul/fix-e2e-tests
branch
from
35a2e33 to
ce2c151
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
e2e tests were broken since upgrading DCE to 0.7.2: this PR fixes them by answering a new prompt asked for every datasource (whether profiling should be enabled or not)
At the same time, I've wrapped the timeout exception that was raised currently, to add a bit more info as to why the e2e test fails (in case we ever add new prompts in DCE)