[K/N] KT-62984: Support @Composable annotation hidden from C export #5375
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SvyatoslavScherbina
left a comment
SvyatoslavScherbina
left a comment
There was a problem hiding this comment.
Sorry for the delay! Could you please also rebase the branch?
| private val hiddenFromObjCAnnotation = FqName("kotlin.native.HiddenFromObjC") | ||
|
|
||
| private fun hasHiddenAnnotation(descriptor: Annotated): Boolean { | ||
| return descriptor.annotations.hasAnnotation(hiddenFromObjCAnnotation) |
Contributor
There was a problem hiding this comment.
Please add a comment explaining the purpose of this condition and the trade-off.
I mean, it checks for HiddenFromObjC while C export has nothing to do with Objective-C, which might be confusing for anyone reading this code.
It is also a bit of a hack, but we decided that it is acceptable. Still, worth mentioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also faced this problem:
When there are some functions or classes marked with
@Composable, and we are targeting Linux with a C export, this problem occurs.This commit fixes this.