Nullify the buffer in when calling ToStringAndClear#566
Merged
Iliya-usov merged 1 commit intoJetBrains:masterfrom Oct 27, 2025
Merged
Nullify the buffer in when calling ToStringAndClear#566Iliya-usov merged 1 commit intoJetBrains:masterfrom
Iliya-usov merged 1 commit intoJetBrains:masterfrom
Conversation
Iliya-usov
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
JetDefaultInterpolatedStringHandler, set the buffer to null instead of clearing it whenToStringAndClearis called.On .NET Framework, if the
StringBuilderhas multiple chunks, callingClearactually allocates a new chunk. An interpolated string handler isn't meant to be reused anyway ("The method should be invoked only once and as the last thing performed on the handler. Subsequent use is erroneous, ill-defined, and may destabilize the process"), so I believe it's better to just set the buffer to null.The extra allocation when shrinking the
StringBuilderhas been removed in .NET Core 2.1, so we could in theory try to keep the call toClearwhen running on .NET Core. However we don't have a netcore target (only netstandard, which can be used in a .net framework application), so I don't think it's worth the trouble.