Typing assist: implement typing assist on delete/backspace inside records#324
Closed
seclerp wants to merge 4 commits intoJetBrains:net222from
seclerp:net213-typing-assist-records
Closed
Typing assist: implement typing assist on delete/backspace inside records#324seclerp wants to merge 4 commits intoJetBrains:net222from seclerp:net213-typing-assist-records
seclerp wants to merge 4 commits intoJetBrains:net222from
seclerp:net213-typing-assist-records
Conversation
Member
|
@seclerp Could you pleas add tests for cases where the typing assist shouldn't do the additional formatting, please? An example for { A = 1 {caret}
B = 1
...Please also consider how this should work next to comments and empty lines. |
Member
Author
|
@auduchinok thanks for that catch, I added missing tests and also improved typing assist. Now when backspace is pressed before record field with preceding empty line (or line with only whitespace symbols) indentation is kept: let record = {
field1 = "Hello"
{caret}field2 = "World"
}Backspace: let record = {
field1 = "Hello"
{caret}field2 = "World"
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements delete/backspace assist for cases when the caret is inside record declaration/instance to help in deletion of redundant whitespace. The feature also works for anonymous records and records with attributes as well.
Examples:
Definition:
Backspace:
Instance:
Delete: